Repository navigation
Contract fixtures for manual 2.3.2; weekly checks also post to the Slack warning channel - #21
Merged
Merged
Conversation
…channel The platform's notification routing puts weekly checks in the WARNING tier: a red run posts to the warning channel, and the self-filed issue is the durable record. This repo already has that channel's webhook (SLACK_WEBHOOK_WARNING, used by publish.yml's notify jobs); weekly.yml filed only the issue. The report job now posts too, with the check's result and the run link, fail-safe as in publish.yml: no secret, or Slack down, logs a warning and never fails the report.
…e issue step curl -f, so a revoked webhook is logged as a warning instead of passing silently; continue-on-error on the step; the header says only a run that does not pass posts.
…e published contract (manual 2.3.2) The server now publishes the manual as 2.3.2, so the contract's texts.sample.json carries the new manual version and sha256, and the manifest lists the file's new hash. Both files are copied byte for byte from the published contract (core is canonical); every file in conformance/v1 matches the published manifest, and the manifest equals https://agentchat.me/contract/v1/conformance/manifest.sha256.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The published contract moved to manual 2.3.2, so this PR first copies its fixtures. Then the alert fix:
weekly.yml(#19) files an issue when a run does not pass, but it posts nothing to Slack. The platform's notification routing puts weekly checks in the WARNING tier: they post to the Slack warning channel, and the self-filed issue is the durable record. This repo already has that webhook (SLACK_WEBHOOK_WARNING, used bypublish.yml's notify jobs). I missed it in #19 because I only looked for alerting inci.yml.What changes
conformance/v1/texts.sample.json(the manual's version and sha256) andmanifest.sha256are copied byte for byte from core main at 30e631d.conformance/v1/matches the live manifest.weekly.yml's report job now posts to the warning channel when a run does not pass, with the check's result and the run link.The post can never stop the issue step (
continue-on-error). A missing secret, a revoked webhook (curl -f) or an unreachable Slack logs a warning. The issue step runs as before.Proof
scripts/check-contract-fixtures.shmatches the live manifest.curl:{"text": …};SLACK_WEBHOOK_WARNING not set — skippedand exits 0.Test plan