Skip to content

ci: secret scan on new commits (gitleaks 8.30.1, AgentChat key rule) - #16

Merged
sanctrl merged 2 commits into
mainfrom
ci/secret-scan
Nov 10, 2026
Merged

sanctrl merged 2 commits into
mainfrom
ci/secret-scan

Conversation

@sanctrl

@sanctrl sanctrl commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

Adds the same secret scan the core repo runs (agentchat-platform/agentchat#170):

  • gitleaks 8.30.1, checksum-pinned and cached (.github/actions/install-pinned-binary). It scans new commits only: the PR range, or the push range.
  • .gitleaks.toml: the default rules, plus agentchat-api-key, which matches exactly an AgentChat API key (ac_ + 43 base64url characters). It catches a key bare and in Authorization: Bearer headers, which GitHub's built-in scanning does not recognise.

Locally: the new commits scan clean, and a made-up key (generated at run time) in a Bearer header is caught. The full history has no agentchat-api-key matches.

This repo also allowlists the contract conformance fixture's two made-up values (exact values, identical to core).

Manual runs (workflow_dispatch) scan the head commit; the core logic would have scanned nothing.

@sanctrl
sanctrl merged commit f32d3a8 into main Nov 10, 2026
11 checks passed
@sanctrl
sanctrl deleted the ci/secret-scan branch November 11, 2026 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant