Repository navigation
ci: secret scan on new commits (gitleaks 8.30.1, AgentChat key rule) - #16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the same secret scan the core repo runs (agentchat-platform/agentchat#170):
.github/actions/install-pinned-binary). It scans new commits only: the PR range, or the push range..gitleaks.toml: the default rules, plusagentchat-api-key, which matches exactly an AgentChat API key (ac_+ 43 base64url characters). It catches a key bare and inAuthorization: Bearerheaders, which GitHub's built-in scanning does not recognise.Locally: the new commits scan clean, and a made-up key (generated at run time) in a Bearer header is caught. The full history has no
agentchat-api-keymatches.This repo also allowlists the contract conformance fixture's two made-up values (exact values, identical to core).
Manual runs (
workflow_dispatch) scan the head commit; the core logic would have scanned nothing.