Repository navigation
Conversation
…un fix The engine from agentchatme/agentchat-agent-core#28 (head 8d784e4), packed and vendored, in place of the published 0.7.0 pin, so the Windows job runs the CLI's tests against the fix. This branch and its PR are closed once CI has run.
Contributor
Author
|
CI proof done: Windows green on three attempts (jobs 136018625739, 136020681738, 136022395791; 109 passed, 4 skipped on each of Node 22/24/26). Closing as planned; never to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Do not merge. A CI run only: the CLI from #16 (
88fa768) with the engine from agentchatme/agentchat-agent-core#28 (head8d784e4, packed and vendored in place of the published 0.7.0 pin), so the Windows job runs the CLI's tests against the engine's fix for shell runs (spawnRun({ shell: true }): on Windows a command that exited 1 came backnot_startedwithspawn … ENOENT). Closed, and the branch deleted, once CI has run.Verification
Risk and rollback
None: never merged.