Repository navigation
feat(profile): own is the default — reply runs use your own Claude Code permission settings - #22
Merged
Merged
Conversation
…de permission settings The engine's new `own` profile (agent-core) becomes this integration's default: reply runs use the user's own Claude Code permission settings, with anything that would ask refused; runs started by peers' messages act with those permissions. help, install, daemon install and doctor say what the active profile does; README and changelog carry the upgrade note (installs that never set AGENTCHAT_RUN_PROFILE move from answer to own). Builds and passes on the pinned engine; the own tests run once the pin moves.
…for idle status; texts A tagged release's tests fail unless the bundled engine has the own profile (the publish workflow's gate job runs them for the tag), so these texts cannot ship on the old engine; pull requests stay green on the pin. The runner factory names its runtime, so status says it while idle. The known limits (Windows, plan mode, a key a 0.5.2 placement left in .env) are said.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Reply runs act as the agent itself. The default run profile is
own: reply runs use your own Claude Code permission settings, with anything that would ask refused. Runs started by peers' messages act with those permissions. The flags are the engine's (agentchatme/agentchat-agent-core#22):CLAUDE.md, memory and hooks apply. The integration's user-scopeagentchatentry, with its headers helper, is the run's AgentChat server.cat,head,tail,sedandteein the shell.AGENTCHAT_API_KEYthe daemon inherited is dropped.~/.claude/agentchat-answer-workdirinstead of the home folder.answeris the lock and an explicit opt-in, unchanged; a value that names no profile isanswer.workandfullare unchanged.--helplistsown|answer|work|fullwith theownline.daemon installsay what the active profile does.doctor'srun-profilesays theownline, the honest sentence and where runs work.run-workdirsays when own runs use the fallback folder.statusshows the profile line from the engine.ownsection with an upgrade note, the known limits and the live-check results. The changelog leads with the upgrade note.AGENTCHAT_RUN_PROFILEmoves fromanswertoownonce the upgraded daemon restarts. To keep the lock:AGENTCHAT_RUN_PROFILE=answer npx -y @agentchatme/claude-code daemon install.nodeorpythonscript) can readcredentials.~/.claude, where Claude Code asks before every edit, so runs there edit nothing.defaultMode: planstops even the AgentChat tools.Needs the new engine release before this is released. This PR builds and passes against the pinned
@agentchatme/agent-core0.5.2. On 0.5.2 the daemon still resolves the old profiles (defaultanswer), and the tests that needownare skipped (ENGINE_HAS_OWN). A tagged release's tests fail until the pin moves (tests/version-consistency.test.ts, run for the tag by the publish workflow's gate job), so a release cannot ship these texts on the old engine. They run, and pass, once the pin moves to the engine release withown. Merge the engine PR first. Move the pin at the release step. No version number is set here.Verification
pnpm type-check,pnpm build,pnpm testandscripts/release-smoke.shon Node 22 (macOS), both ways.profile own — reply runs use your own Claude Code permission settings ….ownwords, and that they equal the engine's.--mcp-config/--strict-mcp-config/--tools/--settings/--permission-mode; the identity line appended; the deny rules; no inherited key in the environment; no file left behind.runPointerfor own.doctorwith the default profile, and withpermissions.additionalDirectoriesset (own is not refused).own, withruntime_labelin its status.tests/version-consistency.test.ts): on a tag build it fails unless the engine hasown; it fails on the pinned 0.5.2 withGITHUB_REF_TYPE=tag.answerbeing the default now set it explicitly.ownrun did not overridebearer_token_env_var. Over a config a 0.5.2 Codex integration left (that variable, the key in$CODEX_HOME/.env), it would have authenticated as that integration's agent and carried its key. Such runs now refuse, verified live (engine PR).own.sh -c.owntest asserts on the environment of the spawned run.cmd /Cquoting of the helper. Codex wraps the command in one more pair of quotes (raw_arg(""<command>""),rmcp-client/src/http_headers.rs:446).describeMcpandworkwording.doctorshows PASS forowneven when the user's own settings amount tofull.HOME/CLAUDE_CONFIG_DIR, with a scripted fake model API, a local fake MCP server behind a user-scopeagentchatentry with a headers helper, and a fake key. The engine's own runner, built, started the runs (see the engine PR for the full list).Bash(echo:*)rule ran; the user's hook ran and CLAUDE.md was in context.touch,Write,Read/catofcredentialsand.claude.json(even with a userBash(cat:*)rule), and a read outside the work folder.AGENTCHAT_API_KEYin its environment, and the model never saw the key.statusshowsprofile: own (claude) — reply runs use your own Claude Code permission settings ….Risk and rollback
answer.ownwhile runs areanswer. That is the stricter direction, and it is why the pin must move first.AGENTCHAT_RUN_PROFILE=answeranddaemon install.