Wait on the correct Deployment name when deploying atenet-dns#542
Open
Chuang Wang (chuangw6) wants to merge 1 commit into
Open
Wait on the correct Deployment name when deploying atenet-dns#542Chuang Wang (chuangw6) wants to merge 1 commit into
Chuang Wang (chuangw6) wants to merge 1 commit into
Conversation
The Deployment in manifests/ate-install/atenet-dns.yaml is named "dns", while every other resource in that file is named "atenet-dns". The rollout check waited on deployment/atenet-dns, so --deploy-atenet exited non-zero with Error from server (NotFound): deployments.apps "atenet-dns" not found on every otherwise successful deploy, after the router rollout had already been confirmed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Deployment in
atenet-dns.yamlis nameddns; every other resource in that file isatenet-dns. The installer waited on the filename rather than the actual Deployment, so this step failed with NotFound on every otherwise-successful deploy.