Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions reviews/SR-1613-code-review.comment.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
<!-- reviewer repo=agent-ix/spec-objects-security visibility=public quoin=0.35.0 module=spec-objects-security@9bf425fc id=SR-1613 method=code-review lang=py pr=spec-objects-security#65 model=gpt-6.1-sol run=3548c9d2-949f-427a-9f73-a76ca26647b9 -->

| FND | Severity | Check | Summary |
| --- | --- | --- | --- |
| FND-001 | high | soundness | The new _extract helper duplicates tests/test_regulated_categories.py::_extract: it loads schema documents, composes module mappings and source identity, then invokes extract_semantic with dataSchema and bodyExtraction. This creates two implementations that can drift; reuse or generalize the existing helper. |

+++ [reviewer data]

```yaml
clean: false
scope:
- id: tests/test_trust_boundary.py::_extract
path: tests/test_trust_boundary.py
role: examined
excerpt: Semantic extraction helper loads schemas and invokes extract_semantic with
the module mappings, source identity, data schema, and body extraction.
- id: tests/test_regulated_categories.py::_extract
path: tests/test_regulated_categories.py
role: context_only
excerpt: Existing helper performs the same semantic extraction setup with schema
documents, module mappings, source identity, and bodyExtraction.
findings:
- fnd: FND-001
severity: high
confidence: high
method: code-review
check: soundness
artifact_id: tests/test_trust_boundary.py::_extract
related_ids:
- tests/test_regulated_categories.py::_extract
path: tests/test_trust_boundary.py
lines: 20-42
excerpt: The trust_level frontmatter extraction path has separate coverage in test_trust_boundary.py.
finding: 'The new _extract helper duplicates tests/test_regulated_categories.py::_extract:
it loads schema documents, composes module mappings and source identity, then
invokes extract_semantic with dataSchema and bodyExtraction. This creates two
implementations that can drift; reuse or generalize the existing helper.'
bindings: []
```

+++
46 changes: 46 additions & 0 deletions reviews/SR-1614-gap-analysis.comment.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
<!-- reviewer repo=agent-ix/spec-objects-security visibility=public quoin=0.35.0 module=spec-objects-security@9bf425fc id=SR-1614 method=gap-analysis lang=spec pr=spec-objects-security#65 model=gpt-6.1-sol run=3548c9d2-949f-427a-9f73-a76ca26647b9 -->



+++ [reviewer data]

```yaml
clean: true
scope:
- id: FR-024-AC-1
path: spec/functional/FR-024-trust-boundary-trust-level.md
role: examined
excerpt: A trust_boundary with a valid trust_level frontmatter value passes quire
validate.
- id: FR-024-AC-2
path: spec/functional/FR-024-trust-boundary-trust-level.md
role: examined
excerpt: A trust_boundary without frontmatter trust_level fails validation and names
the missing field.
- id: FR-024-AC-3
path: spec/functional/FR-024-trust-boundary-trust-level.md
role: examined
excerpt: A trust_level outside the allowed enum fails validation and names the value.
- id: FR-024-AC-4
path: spec/functional/FR-024-trust-boundary-trust-level.md
role: examined
excerpt: 'trust_level: untrusted is extracted as the record key trust_level with
value untrusted.'
- id: FR-024-AC-5
path: spec/functional/FR-024-trust-boundary-trust-level.md
role: examined
excerpt: The TrustBoundary schema rejects crosses, admits a valid typed trust_level,
and keeps the TrustLevelField item rule.
- id: FR-024-AC-6
path: spec/functional/FR-024-trust-boundary-trust-level.md
role: examined
excerpt: The trust-boundary skeleton carries valid frontmatter trust_level and validates.
- id: FR-024-AC-7
path: spec/functional/FR-024-trust-boundary-trust-level.md
role: examined
excerpt: Removing frontmatter leaves no extracted trust_level and validation fails.
findings: []
bindings: []
```

+++
20 changes: 20 additions & 0 deletions reviews/SR-1615-spec-review-base.comment.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
<!-- reviewer repo=agent-ix/spec-objects-security visibility=public quoin=0.35.0 module=spec-objects-security@9bf425fc id=SR-1615 method=spec-review/base lang=spec pr=spec-objects-security#65 model=gpt-6.1-sol run=3548c9d2-949f-427a-9f73-a76ca26647b9 -->



+++ [reviewer data]

```yaml
clean: true
scope:
- id: FR-024
path: spec/functional/FR-024-trust-boundary-trust-level.md
role: examined
excerpt: 'Each trust_boundary SHALL author frontmatter trust_level with exactly
one value from the existing TrustLevel enumeration: untrusted, semi_trusted, trusted,
or unknown.'
findings: []
bindings: []
```

+++
20 changes: 20 additions & 0 deletions reviews/SR-1616-spec-review-ears-conformance.comment.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
<!-- reviewer repo=agent-ix/spec-objects-security visibility=public quoin=0.35.0 module=spec-objects-security@9bf425fc id=SR-1616 method=spec-review/ears-conformance lang=spec pr=spec-objects-security#65 model=gpt-6.1-sol run=3548c9d2-949f-427a-9f73-a76ca26647b9 -->



+++ [reviewer data]

```yaml
clean: true
scope:
- id: FR-024
path: spec/functional/FR-024-trust-boundary-trust-level.md
role: examined
excerpt: 'Each trust_boundary SHALL author frontmatter trust_level with exactly
one value from the existing TrustLevel enumeration: untrusted, semi_trusted, trusted,
or unknown.'
findings: []
bindings: []
```

+++
19 changes: 19 additions & 0 deletions reviews/SR-1617-spec-review-integrity.comment.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<!-- reviewer repo=agent-ix/spec-objects-security visibility=public quoin=0.35.0 module=spec-objects-security@9bf425fc id=SR-1617 method=spec-review/integrity lang=spec pr=spec-objects-security#65 model=gpt-6.1-sol run=3548c9d2-949f-427a-9f73-a76ca26647b9 -->



+++ [reviewer data]

```yaml
clean: true
scope:
- id: FR-024-AC-5
path: spec/functional/FR-024-trust-boundary-trust-level.md
role: examined
excerpt: The TrustBoundary schema rejects a record containing crosses, while a valid
typed trust_level is admitted; the TrustLevelField item rule remains.
findings: []
bindings: []
```

+++
43 changes: 43 additions & 0 deletions reviews/SR-1619-spec-review-dependency.comment.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
<!-- reviewer repo=agent-ix/spec-objects-security visibility=public quoin=0.35.0 module=spec-objects-security@9bf425fc id=SR-1619 method=spec-review/dependency lang=spec pr=spec-objects-security#65 model=gpt-6.1-sol run=3548c9d2-949f-427a-9f73-a76ca26647b9 -->

| FND | Severity | Check | Summary |
| --- | --- | --- | --- |
| FND-001 | medium | soundness | FR-024 depends on architecture FR-014 even though trust-level extraction, validation, and the security record shape stand independently. FR-014 depends on FR-024 to report trust_level, so this reverse depends_on edge creates a circular dependency. Remove FR-024 → FR-014; state that connection edges are architecture-owned without making trust-level extraction depend on the crossing feature. |

+++ [reviewer data]

```yaml
clean: false
scope:
- id: FR-024
path: spec/functional/FR-024-trust-boundary-trust-level.md
role: examined
excerpt: 'relationships: depends_on FR-004; depends_on FR-023; depends_on architecture
FR-014.'
- id: FR-014
path: ix://agent-ix/spec-objects-architecture/FR-014
role: context_only
excerpt: FR-014 reports each crossing target with its trust_level, requiring the
TrustBoundary trust_level field.
findings:
- fnd: FND-001
severity: medium
confidence: high
method: spec-review/dependency
check: soundness
artifact_id: FR-024
related_ids:
- FR-014
path: spec/functional/FR-024-trust-boundary-trust-level.md
lines: 2-9
excerpt: "relationships:\n - target: \"ix://agent-ix/spec-objects-architecture/FR-014\"\
\n type: depends_on"
finding: FR-024 depends on architecture FR-014 even though trust-level extraction,
validation, and the security record shape stand independently. FR-014 depends
on FR-024 to report trust_level, so this reverse depends_on edge creates a circular
dependency. Remove FR-024 → FR-014; state that connection edges are architecture-owned
without making trust-level extraction depend on the crossing feature.
bindings: []
```

+++
35 changes: 35 additions & 0 deletions reviews/plat-1532-base.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
---
id: SR-1615
title: "base review — PLAT-1532 spec-objects-security"
type: SpecReview
analysis: base
scope: "agent-ix/spec-objects-security; spec/functional/FR-024-trust-boundary-trust-level.md"
review_set: subset
---

## Summary

The requirement states the trust-level behavior and its verification clearly. One dependency issue is recorded separately in the dependency analysis.

## Verdict

**PASS** — no defects found in this analysis.

## Scope

- Examined: spec/functional/FR-024-trust-boundary-trust-level.md.
- Ticket: PLAT-1532; PR #65; reviewed head `9bf425fc3047401cccaa5fe45adfb76c0af75811`.

## Findings

| ID | Severity | Summary | Refs |
| --- | --- | --- | --- |
| FND-001 | low | No findings (placeholder) | - |

## Evidence

No defect found in the stated scope. The acceptance criteria and relevant tests were examined.

## Examined Units

- `FR-024` (examined): “Each trust_boundary SHALL author frontmatter trust_level with exactly one value from the existing TrustLevel enumeration: untrusted, semi_trusted, trusted, or unknown.”
50 changes: 50 additions & 0 deletions reviews/plat-1532-code-review.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
---
id: SR-1613
title: "code-review review — PLAT-1532 spec-objects-security"
type: SpecReview
analysis: code-review
scope: "agent-ix/spec-objects-security; tests/test_trust_boundary.py; tests/test_role_schemas.py"
review_set: subset
---

## Summary

The new _extract helper repeats the semantic extraction setup already implemented by tests/test_regulated_categories.py::_extract: loading all schema documents, composing module mappings, setting source identity, and calling extract_semantic with dataSchema/bodyExtraction. This creates two implementations that can drift. Reuse or generalize the existing extraction helper.

## Verdict

**FAIL** — a high-severity defect is present.

## Scope

- Examined: tests/test_trust_boundary.py; tests/test_role_schemas.py.
- Ticket: PLAT-1532; PR #65; reviewed head `9bf425fc3047401cccaa5fe45adfb76c0af75811`.

## Findings

| ID | Severity | Summary | Refs |
| --- | --- | --- | --- |
| FND-001 | high | The new _extract helper repeats the semantic extraction setup already implemented by tests/test_regulated_categories.py::_extract: loading all schema documents, composing module mappings, setting source identity, and calling extract_semantic with dataSchema/bodyExtraction | tests/test_trust_boundary.py:20-42 |

## Evidence

The `trust_level` extraction path has separate coverage in `test_trust_boundary.py`.

Observed finding: The new _extract helper repeats the semantic extraction setup already implemented by tests/test_regulated_categories.py::_extract: loading all schema documents, composing module mappings, setting source identity, and calling extract_semantic with dataSchema/bodyExtraction. This creates two implementations that can drift. Reuse or generalize the existing extraction helper.

## Examined Units

- `tests/test_trust_boundary.py::_extract` (examined): “Semantic extraction helper loads schemas and invokes extract_semantic with the module mappings, source identity, data schema, and body extraction.”
- `tests/test_regulated_categories.py::_extract` (context_only): “Existing helper performs the same semantic extraction setup with schema documents, module mappings, source identity, and bodyExtraction.”

## Dispositions

| FND | outcome | reason |
| --- | --- | --- |
| FND-001 | fixed | The trust-boundary test now reuses the generalized `_extract` helper from `test_regulated_categories.py`. |

## Dispositions

| FND | outcome | reason |
| --- | --- | --- |
| FND-001 | fixed | The extraction logic is generalized in `test_regulated_categories.py::_extract`, and `test_trust_boundary.py` now reuses it with the trust_boundary schema and bundle. |
50 changes: 50 additions & 0 deletions reviews/plat-1532-dependency.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
---
id: SR-1619
title: "dependency review — PLAT-1532 spec-objects-security"
type: SpecReview
analysis: dependency
scope: "agent-ix/spec-objects-security; spec/functional/FR-024-trust-boundary-trust-level.md"
review_set: subset
---

## Summary

FR-024 depends on architecture FR-014 even though trust-level extraction, validation, and the security record shape are independently defined and implemented. FR-014 depends on FR-024 to report trust_level, so the reverse edge creates a circular dependency. Remove the FR-024 -> FR-014 depends_on edge; FR-024 can describe that connection edges are owned by architecture without depending on that feature.

## Verdict

**CONDITIONAL** — one medium-severity dependency issue is present.

## Scope

- Examined: spec/functional/FR-024-trust-boundary-trust-level.md.
- Ticket: PLAT-1532; PR #65; reviewed head `9bf425fc3047401cccaa5fe45adfb76c0af75811`.

## Findings

| ID | Severity | Summary | Refs |
| --- | --- | --- | --- |
| FND-001 | medium | FR-024 depends on architecture FR-014 even though trust-level extraction, validation, and the security record shape are independently defined and implemented | spec/functional/FR-024-trust-boundary-trust-level.md:7 |

## Evidence

A trust boundary identifies the zone on its far side and the trust given to that zone. A field row in `## Properties` describes a value but does not supply the value to consumers. The authored boundary therefore states `trust_level` in frontmatter, where the extractor places it in the typed `TrustBoundary` record. Connection crossings are relationship edges owned by the connection and are specified by spec-objects-architecture FR-014; `TrustBoundary` carries no `crosses` record key.

Observed finding: FR-024 depends on architecture FR-014 even though trust-level extraction, validation, and the security record shape are independently defined and implemented. FR-014 depends on FR-024 to report trust_level, so the reverse edge creates a circular dependency. Remove the FR-024 -> FR-014 depends_on edge; FR-024 can describe that connection edges are owned by architecture without depending on that feature.

## Examined Units

- `FR-024` (examined): “relationships: depends_on FR-004; depends_on FR-023; depends_on architecture FR-014.”
- `FR-014` (context_only): “FR-014 reports each crossing target with its trust_level, requiring the TrustBoundary trust_level field.”

## Dispositions

| FND | outcome | reason |
| --- | --- | --- |
| FND-001 | fixed | FR-024 no longer has a `depends_on` edge to architecture FR-014; the text says extraction is independent of the crossing edge. |

## Dispositions

| FND | outcome | reason |
| --- | --- | --- |
| FND-001 | fixed | FR-024 no longer declares a `depends_on` edge to FR-014 and explicitly says trust-level extraction does not depend on the crossing edge. |
35 changes: 35 additions & 0 deletions reviews/plat-1532-ears-conformance.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
---
id: SR-1616
title: "ears-conformance review — PLAT-1532 spec-objects-security"
type: SpecReview
analysis: ears-conformance
scope: "agent-ix/spec-objects-security; spec/functional/FR-024-trust-boundary-trust-level.md"
review_set: subset
---

## Summary

The behavior statements use consistent SHALL phrasing and identify trigger, subject, and required behavior. No EARS conformance defect found.

## Verdict

**PASS** — no defects found in this analysis.

## Scope

- Examined: spec/functional/FR-024-trust-boundary-trust-level.md.
- Ticket: PLAT-1532; PR #65; reviewed head `9bf425fc3047401cccaa5fe45adfb76c0af75811`.

## Findings

| ID | Severity | Summary | Refs |
| --- | --- | --- | --- |
| FND-001 | low | No findings (placeholder) | - |

## Evidence

No defect found in the stated scope. The acceptance criteria and relevant tests were examined.

## Examined Units

- `FR-024` (examined): “Each trust_boundary SHALL author frontmatter trust_level with exactly one value from the existing TrustLevel enumeration: untrusted, semi_trusted, trusted, or unknown.”
Loading
Loading