Repository navigation
Add threat model security object - #64
Merged
Merged
Conversation
added 5 commits
November 15, 2026 17:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
threat_modeltype, method enum, skeleton, schemas, andconsidersedge.threat.threatensto connection, data sink, and trust boundary targets.decided_by.coversedge.Review fixes
coversrelation and test the missing-edge diagnostic.threatensedge to a registered queue type and assert the disallowed-target diagnostic.Verification
quire 0.46.0 (engine 0.61.0) matrix --scope . --module <security module> --module <spec-artifacts-process module> --format tsv— FR-026-AC-1..7 and AC-9..10 all reporttagged; FR-026-AC-8 reportsmethod-without-symbol.quire 0.46.0 validate --scope . --module <security module> --module <spec-artifacts-process module> --strict spec/tests.md— exit 0.locked-build.sh <worktree>/target poetry run pytest tests/test_threat_model.py tests/test_manifest.py --no-cov -q— 65 passed.locked-build.sh <worktree>/target poetry run poe lint— passed (ruff, black, and schema drift check: 59 schemas match).PLAT-1535 and PLAT-1657 remain dependencies; hold merge until both land. The code lead owns the final aggregate gate.
Final aggregate gate and baseline failure
On PR head
dc3c5830917eabae8dbed2c55d10977964b821fb,locked-build.sh <worktree>/target poetry run make test lintcompleted with 416 passed, 1 deselected, 5 xfailed, and one failure. Ruff, Black, and the schema drift check were not reached becausemake teststopped at the failing legacy testtests/test_control_mitigates.py::test_control_mitigating_an_asset_is_a_disallowed_edge_target.The assertion expects
(object type 'asset'); Quire 0.61.0 emitswhose target type 'asset', object 'asset'while reporting the samedisallowed-edge-target. The failing test is unchanged by this PR. It was reproduced on a clean detachedorigin/mainworktree at8765b73c0cfe1dbc6cbe073dd7640f9e5284595busing the same Quire 0.61.0 CLI and environment. This is a moving-main baseline red, not a regression from this PR. Merge past it and record the baseline failure.The only Linear dependency for PLAT-1543 is PLAT-1542, now Done. PLAT-1535 is also Done. PLAT-1657 is a downstream ticket blocked by PLAT-1543, so it does not block this merge.
Final-head verification after main integration
On final head
a5279069559a62e08daa4424d1fbafc14faf642c,locked-build.sh <worktree>/target poetry run make test lintcompleted with 428 passed, 1 deselected, 5 xfailed, and only the same legacytest_control_mitigating_an_asset_is_a_disallowed_edge_targetfailure described above. The two npm-pack tests passed with the npmjs registry,/dev/nulluser config, and writable task cache; no root-level generated manifest/profile files remained.make lintpassed separately on this final head (Ruff, Black, 59 schemas match). The legacy test reproduced on clean main and remains recorded as the only baseline red.