Repository navigation
PLAT-277 F1: do not require record keys whose source section is optional - #29
Merged
Merged
Conversation
Configuration, Migration, Sli, Slo, Alert, Runbook, Incident and Deployment no longer require fields, clauses or operations; item rules still apply when the key is present. The migration-no-invariants negative fixture is a valid document now and is removed. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Correct the TypeSpec doc comments (and the emitted descriptions) that still said a key is required, test what the acceptance criteria say, add document-level tests for a missing optional section, align FR-004 and FR-005 wording, drop FR-006-CON-1 and the hand-kept counts. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLAT-277 finding F1 for spec-objects-operational. No other PR was open on this repo.
typespec/main.tsp+ regenerated schemas: all eight object schemas requiredfields,clausesand/oroperationswhile theirproperties/invariants/operationslocators arerequired: false.Configuration,Sli,Incident(fields),Migration,Slo(fields, clauses),Alert(clauses),Runbook(operations),Deployment(fields, operations) now require nothing. Item rules (minItems, occurrence/identity/unit rules) still apply when the key is present. Locators unchanged.operations: []).@agent-ix/semantic-core0.3.2 from GitHub Packages (401 here). I emitted with the public 0.3.3 package copy locally, with its version label rewritten to 0.3.2 in a scratch node_modules only; on the untouched tree that setup reproduced all 27 committed schemas byte for byte (schemas-checkclean), andschemas-checkis clean on this branch. CI with the real 0.3.2 package should confirm.Tests: ruff and black clean. Local suite 145 passed; the 6 remaining failures are the same six that fail on main in this environment (skeleton/engine tests: the only available quire wheel is 0.54.0 while this repo pins ^0.50.0 / semantic-core 0.3.2), so CI should run them.
🤖 Generated with Claude Code