Skip to content

PLAT-277 F1: do not require record keys whose source section is optional - #29

Merged
kreneskyp merged 4 commits into
mainfrom
plat-277-optional-record-keys
Nov 9, 2026
Merged

kreneskyp merged 4 commits into
mainfrom
plat-277-optional-record-keys

Conversation

@kreneskyp

Copy link
Copy Markdown
Contributor

PLAT-277 finding F1 for spec-objects-operational. No other PR was open on this repo.

  • typespec/main.tsp + regenerated schemas: all eight object schemas required fields, clauses and/or operations while their properties/invariants/operations locators are required: false. Configuration, Sli, Incident (fields), Migration, Slo (fields, clauses), Alert (clauses), Runbook (operations), Deployment (fields, operations) now require nothing. Item rules (minItems, occurrence/identity/unit rules) still apply when the key is present. Locators unchanged.
  • Spec: new FR-006 (AC-1..2), TC-092; FR-004 table, ACs 2-5, 9, 10 and CON-2 updated; FR-005 negative-fixture list updated (migration-no-invariants is now a valid document and is removed; runbook-no-operations stays, an empty Operations section still yields operations: []).
  • Regeneration caveat: this repo pins @agent-ix/semantic-core 0.3.2 from GitHub Packages (401 here). I emitted with the public 0.3.3 package copy locally, with its version label rewritten to 0.3.2 in a scratch node_modules only; on the untouched tree that setup reproduced all 27 committed schemas byte for byte (schemas-check clean), and schemas-check is clean on this branch. CI with the real 0.3.2 package should confirm.

Tests: ruff and black clean. Local suite 145 passed; the 6 remaining failures are the same six that fail on main in this environment (skeleton/engine tests: the only available quire wheel is 0.54.0 while this repo pins ^0.50.0 / semantic-core 0.3.2), so CI should run them.

🤖 Generated with Claude Code

Configuration, Migration, Sli, Slo, Alert, Runbook, Incident and Deployment
no longer require fields, clauses or operations; item rules still apply when
the key is present. The migration-no-invariants negative fixture is a valid
document now and is removed.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@kreneskyp
kreneskyp requested a review from a team as a code owner November 9, 2026 17:23
Agent IX and others added 3 commits November 9, 2026 09:40
Correct the TypeSpec doc comments (and the emitted descriptions) that still
said a key is required, test what the acceptance criteria say, add
document-level tests for a missing optional section, align FR-004 and FR-005
wording, drop FR-006-CON-1 and the hand-kept counts.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@kreneskyp
kreneskyp merged commit 605e92f into main Nov 9, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant