Skip to content

VER-75: declare trace_tags.formalizes manifest form - #158

Merged
kreneskyp merged 1 commit into
mainfrom
ver-75-formalizes-manifest
Nov 15, 2026
Merged

kreneskyp merged 1 commit into
mainfrom
ver-75-formalizes-manifest

Conversation

@kreneskyp

Copy link
Copy Markdown
Contributor

Summary

  • Adds traceability.trace_tags.formalizes with the single qsl-formalizes-comment form (language: qsl, syntax: comment, pattern ^//\s*formalizes:\s*(.*)$, template // formalizes: {ids}), per FR-004-AC-38..40 and quire-rs FR-094.
  • Adds load-level tests TC-227..229 and marks them ✅ in spec/tests.md.
  • The pattern uses (.*) as FR-004-AC-38 pins it. The ticket body's (.+) is stale; the spec wins.
  • No signing, CR notes or key configuration.

Checks run

  • pytest tests/test_traceability_declaration.py tests/test_manifest.py --no-cov: 47 passed, including the three new tests. 10 CLI-backed tests fail, see below.
  • ruff check and black on the touched test file: clean.

Blocker: needs a quire release containing quire-rs#689

Merged quire-rs#689 (2697931) is not in any release. The latest, quire 0.45.0 / engine 0.60.0 (2026-11-13), predates it and rejects the manifest: unknown field formalizes, expected markers or implements. Every test that shells out to quire fails with that load error (10 tests), and so does quire validate. This PR should land only after an engine with #689 is released and installed, and the quire dev dependency in the lock is bumped to it. I did not build an engine from source or touch the lock.

🤖 Generated with Claude Code

Adds the qsl-formalizes-comment form as a third trace_tags list beside
markers and implements, with load-level tests TC-227..229 (FR-004-AC-38..40).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@kreneskyp
kreneskyp requested a review from a team as a code owner November 15, 2026 20:30
@kreneskyp

Copy link
Copy Markdown
Contributor Author

VER-75 PR #158 verification:

  • make lint passed through locked-build.sh; schema projection is current, Ruff passed, and Black reported 23 files unchanged.
  • With the merged quire-rs engine built from the PR source and the VER-75 quire-cli binary selected, make test reached 100% coverage: 542 passed, 1 skipped, 2 xfailed, 3 failed.
  • The three failures are tests/test_adr_links.py::test_adr_realizing_a_part_draws_the_advisory_finding_naming_the_ids, ...::test_adr_realizing_a_missing_id_fails_strict_with_a_located_error, and ...::test_relations_report_the_adr_as_realizing_fr_and_nfr. All three were reproduced on a clean origin/main worktree at bfce4fc with the same CLI and engine. They report that no loaded module declares traceability.required_relations and missing role registrations. These are existing main failures.
  • The complete tests/test_traceability_declaration.py set passed (39 tests) with the current CLI; the three new formalizes declaration tests pass.

The scoped gate and lint are green. The three full-suite reds are reproduced on clean main and are recorded here per the moving-main rule.

@kreneskyp
kreneskyp merged commit d2b59c2 into main Nov 15, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant