Repository navigation
PLAT-1615: extend DossierDocument for M2 kinds - #157
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends DossierDocument with the six M2 kinds in TypeSpec, projected record and frontmatter schemas, skeleton, golden record and tests. RMM requires
as_of. SOUP accepts an unbound gap document withoutas_of; FR-197 requires the supplied instant when a SOUP binding is present.Review disposition
fails_namingfor the frontmatter diagnostic, corrected TC-232, added TC-243–245 and trace tags, listed all six kinds in AC-14, and split frontmatter/record coverage into AC-15/16.as_ofownership rule, named the SOUP list consistently and added downstream quoin FR-196–201 references.as_offor that document. The source-backed rule belongs to quoin FR-197.Validation
quire validateon FR-018 and the DossierDocument skeleton: exit 0 after the latest edits.git diff --check: exit 0 after the latest edits.quire matrix --format tsv: AC-14/15/16 tagged after the trace changes.quire validate spec/tests.mdexits 3 because TestMatrix lacksfunctional_coverage; the same result reproduces from cleanorigin/main:spec/tests.md. This is a pre-existing red.