Skip to content

Fix Telegram NyxID binding prompts - #3605

Merged
louis4li merged 2 commits into
feature/integratefrom
fix/2026-09-08_telegram-nyxid-binding-prompts
Sep 8, 2026
Merged

Fix Telegram NyxID binding prompts#3605
louis4li merged 2 commits into
feature/integratefrom
fix/2026-09-08_telegram-nyxid-binding-prompts

Conversation

@louis4li

@louis4li louis4li commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Avoid duplicate Telegram OAuth links in the NyxID /init reply by keeping the URL only on the action button for Telegram.
  • Render NyxID binding retry and callback success copy with the actual channel platform instead of hardcoded Lark wording.
  • Add identity channel regression coverage for Telegram /init and callback HTML copy.

Test plan

  • dotnet test test/Aevatar.GAgents.ChannelRuntime.Tests/Aevatar.GAgents.ChannelRuntime.Tests.csproj --nologo --no-restore --filter "FullyQualifiedName~Identity" --verbosity quiet -clp:ErrorsOnly
  • bash tools/ci/test_stability_guards.sh
  • git diff --check

🤖 Generated with Claude Code

Avoid duplicate Telegram OAuth links and render channel binding retry/success copy using the actual platform instead of hardcoded Lark text.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@louis4li
louis4li requested a review from jason-aelf as a code owner September 8, 2026 07:41
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-08T07:45:53.094642Z b4d29ed PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b4d29ed423

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.44%. Comparing base (e483895) to head (8d7cef3).
⚠️ Report is 1 commits behind head on feature/integrate.

@@                  Coverage Diff                  @@
##           feature/integrate    #3605      +/-   ##
=====================================================
- Coverage              83.44%   83.44%   -0.01%     
=====================================================
  Files                   1709     1709              
  Lines                 197728   197728              
  Branches               23735    23735              
=====================================================
- Hits                  165004   164998       -6     
- Misses                 21683    21691       +8     
+ Partials               11041    11039       -2     
Flag Coverage Δ
ci 83.44% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@louis4li
louis4li merged commit 43ddba6 into feature/integrate Sep 8, 2026
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant