Skip to content

Support targeted workflow delivery service bindings - #3595

Open
louis4li wants to merge 3 commits into
feature/integratefrom
fix/2026-09-07_delivery-connection-slot-pointers
Open

Support targeted workflow delivery service bindings#3595
louis4li wants to merge 3 commits into
feature/integratefrom
fix/2026-09-07_delivery-connection-slot-pointers

Conversation

@louis4li

@louis4li louis4li commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add a typed YamlPointer to workflow delivery connection slots so package authors can bind each external service slot to an explicit YAML location.
  • Render multiple connection references by their declared package pointers instead of replacing every user_service_id node globally.
  • Keep the merchant-style scenario as generic contract/test coverage without adding Telegram or Google demo branches to runtime code.

Test plan

  • dotnet test test/Aevatar.Studio.Tests/Aevatar.Studio.Tests.csproj --no-restore --nologo -clp:ErrorsOnly
  • bash tools/ci/test_stability_guards.sh
  • bash tools/ci/architecture_guards.sh

🤖 Generated with Claude Code

Allow delivery packages to map each external connection slot to an explicit workflow YAML location so multi-service merchant workflows can stay package-driven instead of runtime-special-cased.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@louis4li
louis4li requested a review from jason-aelf as a code owner September 7, 2026 07:32
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-07T07:36:44.996622Z e454510 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e4545102e2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Aevatar.Studio.Application/Delivery/WorkflowDeliveryConfigurationRenderer.cs Outdated
@codecov

codecov Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.45%. Comparing base (87dcf83) to head (8da4cb2).
⚠️ Report is 5 commits behind head on feature/integrate.

@@                  Coverage Diff                  @@
##           feature/integrate    #3595      +/-   ##
=====================================================
+ Coverage              83.44%   83.45%   +0.01%     
=====================================================
  Files                   1709     1709              
  Lines                 197727   197730       +3     
  Branches               23735    23735              
=====================================================
+ Hits                  164989   165013      +24     
+ Misses                 21696    21677      -19     
+ Partials               11042    11040       -2     
Flag Coverage Δ
ci 83.45% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...s/Studio/Abstractions/WorkflowDeliveryContracts.cs 88.29% <100.00%> (+0.04%) ⬆️
...ces/ActorDispatchWorkflowDeliveryCommandService.cs 69.81% <100.00%> (+0.05%) ⬆️
.../QueryPorts/ProjectionWorkflowDeliveryQueryPort.cs 68.16% <100.00%> (+0.21%) ⬆️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

louis4li and others added 2 commits September 7, 2026 17:14
Fail closed when package connection slots target the same YAML location so each external service binding remains unambiguous through catalog, actor, and projection paths.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Fail closed when delivery connection YAML pointers overlap configuration fields, and clear omitted optional connection slots so package defaults cannot leak into installed workflows.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant