replace key worker with elixir-wallet #132

Activity

1. thepiwo commented on Dec 4, 2017

   

   thepiwo

   on Dec 4, 2017

   ContributorAuthor

   More actions

   I guess @gspasov would be ideal to do this task
2. gspasov commented on Jan 5, 2018

   

   gspasov

   on Jan 5, 2018

   Contributor

   More actions

   @thepiwo Should I add the elixir-wallet as a separate app, or just change the functionality of the Keys module?
3. thepiwo commented on Jan 5, 2018

   

   thepiwo

   on Jan 5, 2018

   ContributorAuthor

   More actions

   The elixir wallet should be included as hex dependency and the Key Manager should be removed. Wherever the Key Manager is called functions from the wallet should be called now
4. gspasov

   assigned

   gspasov

   and

   HristianHristov

   on Jan 5, 2018
5. gspasov

   added

   enhancement

   on Jan 5, 2018
6. gspasov commented on Jan 5, 2018

   

   gspasov

   on Jan 5, 2018

   Last edited by gspasov

   Contributor

   More actions

   @thepiwo Looking at the Keys module, it seems that I won't be able just to remove it and use the functionality from the elixir-wallet, because in this module there are some things that I cannot do simply with the elixir-wallet functions. Maybe I can alter the module to such extend that I use the functions from the elixir-wallet, but leave the other stuff.

   Edit: Maybe if I move the sign_tx() function inside the SignedTx module it could work, and I could remove the whole Keys module
7. thepiwo commented on Jan 5, 2018

   

   thepiwo

   on Jan 5, 2018

   ContributorAuthor

   More actions

   signing should work with the wallet as well, what other issues are there?
8. gspasov commented on Jan 5, 2018

   

   gspasov

   on Jan 5, 2018

   Contributor

   More actions

   There is a signing functionality in the wallet, but the signing function in the core is different in the way that it actually creates the Tx itself:

   def sign_tx(to_acc, value, nonce, fee, lock_time_block \\ 0) do
       {:ok, from_acc} = pubkey()
       {:ok, tx_data} = TxData.create(from_acc, to_acc, value, nonce, fee, lock_time_block)
       {:ok, signature} = sign(tx_data)
       signed_tx = %SignedTx{data: tx_data, signature: signature}
       {:ok, signed_tx}
     end
9. thepiwo commented on Jan 5, 2018

   

   thepiwo

   on Jan 5, 2018

   ContributorAuthor

   More actions

   yeah you can put this function in the SignedTx and call the wallet code from there

   👍React with 👍1Reacted by Georgi Spasov
10. gspasov commented on Jan 5, 2018

    

    gspasov

    on Jan 5, 2018

    Last edited by gspasov

    Contributor

    More actions

    @thepiwo
    @meivantodorov
    Edited: Blockers: This pull request should be accepted before we continue our work. I have fixed the namings of the modules.
11. gspasov

    added 4 commits that reference this issue on Jan 9, 2018

    [GH-#132] Added the elixit-wallet as dependency, made the tx test wit…

    ...

    773d590

    [GH-132] Added a test wallet inside the test folder. Refactored the s…

    ...

    ded6c13

    [GH-#132] Fixed the aecore_txs_pool_test. Made cretion of Miner walle…

    ...

    e389989

    [GH-132] Fixed the aecore_validation_test. Deleted the aecore_keys_test

    34bf542
12. 24 remaining items

    Load more
13. gspasov

    added 11 commits that reference this issue on Feb 19, 2018

    [GH-132] Fixed the term_to_binary usages

    94d8720

    [GH-#132] Fixed encode/decode funcs and style problems in the PR

    d25be0c

    [GH-#132] Removed the path variable from the state of the wallet module

    5749eba

    [GH-#132] Fixed the state of the Wallet module, fixed the aehttpclien…

    ...

    8ba78a2

    [GH-#132] Made it possible to derive keys from a given path. Fixed te…

    ...

    78245fc

    [GH-#132] Fixed Travis error

    299e66d

    Merge branch 'master' into GH-132

    d20ead1

    Revert "[GH-#132] Fixed Travis error"

    ...

    0ae4b6b

    [GH-132] Fixing tests after merge

    a21ff8a

    [GH-132] Fixing aehttpserver error

    1f4856e

    [GH-132] Fixing aehttpserver error

    7478329
14. thepiwo

    closed this as completedin #201on Mar 1, 2018
15. thepiwo

    added a commit that references this issue on Mar 1, 2018

    Merge pull request #201 from aeternity/GH-132

    ...

    4a0a98d
16. gspasov

    added 2 commits that reference this issue on Mar 8, 2018

    [GH-#203] Megred with branch #132, resolved conflicts, started fixing…

    ...

    dbf388c

    [GH-203] Fixed all test when merged with branch #132

    d3ff296