Skip to content

add cdr ticket scan count - #1071

Merged
Luhmos merged 4 commits into
mainfrom
cdr-scan-count
Sep 4, 2026
Merged

add cdr ticket scan count#1071
Luhmos merged 4 commits into
mainfrom
cdr-scan-count

Conversation

@Luhmos

@Luhmos Luhmos commented Sep 4, 2026

Copy link
Copy Markdown
Member

Description

Summary

This pr adds the scan count for every ticket generator in the endpoint giving all products for a given seller id (used on the purchases module in titan). It also adds utils for model to schema conversion.
...

Issues/PR dependencies

Issues to be resolved

Required PRs

Changes Made

  • ...
  • ...

Additional Notes

Classification

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)
  • 🔧 Infra CI/CD (changes to configs of workflows)
  • 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)
  • 😶‍🌫️ No impact for the end-users

Impact & Scope

  • Core functionality changes
  • Single module changes
  • Multiple modules changes
  • Database migrations required
  • Other: ...

Testing

  • 1. Tested this locally
  • 2. Added/modified tests that pass the CI (or tested in a downstream fork)
  • 3. Tested in a deployed pre-prod
  • 0. Untestable (exceptionally), will be tested in prod directly
  • 4. Did not test anything here either

Documentation

  • Updated the docs accordingly :
  • " Docstrings
  • # Inline comments
  • No documentation needed

@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 51.50%. Comparing base (606800c) to head (888cfc7).

Files with missing lines Patch % Lines
app/modules/cdr/utils_cdr.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1071       +/-   ##
===========================================
- Coverage   84.91%   51.50%   -33.42%     
===========================================
  Files         220      220               
  Lines       16358    16378       +20     
===========================================
- Hits        13891     8436     -5455     
- Misses       2467     7942     +5475     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Luhmos
Luhmos merged commit 10bc9c7 into main Sep 4, 2026
7 checks passed
@Luhmos
Luhmos deleted the cdr-scan-count branch September 4, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants