fix(webhooks)!: honor durable authentication and operation IDs - #1094
Merged
Conversation
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — clean webhooks PR, no blocking or medium findings.
Checked:
- Breaking change (ReportingWebhook.operation_id → required) is correctly signaled: fix(webhooks)! + BREAKING CHANGE footer + MIGRATION_v7_to_v8.md note. Semver signal on public surface satisfied.
- Generated-code edits pair with tracked schemas/patches and SCHEMA_DELTAS — regeneration output, not hand-edits.
- Security hardening verified: legacy Bearer/HMAC creds AES-256-GCM encrypted at rest, redacted from repr, scrubbed from persisted last_error; HMAC fail-closed behind legacy_hmac_fallback + advertised capability with boot-time alignment.
- Operational readiness: legacy sender IP-pinned, lease-bounded timeout, closed per-attempt in finally; pre-feature RFC bodies round-trip byte-identically. Heavy test coverage.
Gate check: gated_paths is false. high_risk is true, but all reasons are (modified) schema/decisioning files or (added) patch files — no deletions, and no medium-or-higher findings on any modified file, so rows 3–5 do not fire. No author team gate. No prior decision. review_decision is REVIEW_REQUIRED but gated_paths is false, so row 2 does not apply. Zero findings → falls through to row 9: approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReportingWebhook.operation_idacross canonical schemas, generated models, stubs, and migration guidanceValidation
Closes #1091
Closes #1092
BREAKING CHANGE:
ReportingWebhook.operation_idis now required so scheduled delivery webhooks can echo a buyer-supplied correlation identifier.