Skip to content

fix(ladon): use native structured review output - #13

Merged
bokelley merged 1 commit into
mainfrom
fix/ladon-native-structured-output
Aug 26, 2026
Merged

fix(ladon): use native structured review output#13
bokelley merged 1 commit into
mainfrom
fix/ladon-native-structured-output

Conversation

@bokelley

Copy link
Copy Markdown

Summary

  • replace the reviewer's best-effort findings-file Write with Claude Code Action's native --json-schema output
  • pass schema-validated findings directly to the arbiter and keep missing output fail-closed
  • remove filesystem write permission from the reviewer
  • add a manifest regression test for the structured-output contract

This fixes the repeated Reviewer did not write a findings file failures seen on adcontextprotocol/adcp#6794 after otherwise successful reviews.

Verification

  • npm run test (155 tests)
  • isolated TypeScript checks for all three workspaces
  • direct ncc builds for setup, arbiter, and versioning actions
  • Prettier/Biome and git diff --check

@bokelley
bokelley merged commit 24fff56 into main Aug 26, 2026
3 checks passed
@bokelley
bokelley deleted the fix/ladon-native-structured-output branch August 26, 2026 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant