Enhance CI workflow with PHP compatibility checks and coverage updates - #56
Merged
Conversation
- Add root declaration to .editorconfig - Add concurrency control and read permissions to tests workflow - Enable fail-fast: false for matrix builds - Use ramsey/composer-install action for dependency caching - Separate coverage runs from regular test runs to speed up CI - Add php-coveralls as a pre-installed tool for analysis job - Bump actions/checkout to v7 - Add phpcompatibility/php-compatibility for PHP version checks - Export-ignore composer.lock in .gitattributes
Replace php-coveralls tool with the official coverallsapp/github-action for uploading coverage results. Also bump ramsey/composer-install to v4. This simplifies the workflow by removing the need to install the php-coveralls tool separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and refinements across the codebase, documentation, and developer tooling for the project. The main focus is on enhancing static analysis, code quality, and documentation accuracy, while also updating the CI workflow and adding developer conveniences. Below are the most significant changes grouped by theme.
Static Analysis, Linting, and Testing Improvements:
phpstan-phpunitextensions, and adjusted configuration to better match the project's needs (phpstan.neon.dist,composer.json). [1] [2] [3]phpcompatibility/php-compatibilityand related plugins, and updatedphpcs.xml.distto enforce compatibility with PHP 7.4+ (composer.json,phpcs.xml.dist). [1] [2]phpunit.xml.dist). [1] [2]push, integer key handling inset, and more granularcountbehaviors (tests/DotTest.php). [1] [2] [3] [4] [5]Continuous Integration and Workflow Updates:
.github/workflows/tests.yml). [1] [2].gitattributesto excludecomposer.lockfrom exports, reducing unnecessary files in distribution (.gitattributes).Codebase Enhancements and Bug Fixes:
Dotclass: fixed type annotations, improved handling of non-string keys inset, clarified behavior ofpushandcount, and added PHPStan ignore for a specific type inference issue (src/Dot.php). [1] [2] [3] [4] [5] [6] [7]dot()helper to allow calling without arguments (src/helpers.php).Documentation Updates:
README.mdforcount,push, andreplacemethods, updated PHP code examples for modern syntax, and improved instructions for static analysis and JSON output options (README.md). [1] [2] [3] [4] [5] [6] [7]Developer Tooling:
.editorconfigfor consistent editor settings and expandedMakefilewith more targets and improved phony handling (.editorconfig,Makefile). [1] [2]