Conversation
PDGGK
marked this pull request as ready for review
October 3, 2026 06:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The whitespace table added in #483 can strip ordinary field bytes with ASCII and Latin-1 encodings. Node truncates Unicode code points when encoding these characters: U+205F becomes
_, U+202F becomes/, and other whitespace characters collide with ordinary data.For example, parsing
_alice,/home,(draft)with ASCII encoding and trimming changes the field values toalice,home,draft).Change
Build on #483's whitespace-table design by retaining a whitespace sequence only when it round-trips through the configured encoding. This preserves representable whitespace, encoding aliases, and the existing UTF-8/UTF-16 whitespace table without changing parser state handling.
This does not claim byte-for-byte parity with
String.trim()for arbitrary raw high-bit ASCII bytes such as0xA0. Existing buffer-output mode withtrim: trueremains outside this fix.The patch contains source and regression tests only, following #483. Generated distributions were rebuilt and checked; they are not included as release artifacts.
Validation