Support Temurin on Linux RISC-V - #1269
Open
yawkat wants to merge 3 commits into
Open
Conversation
Co-Authored-By: multicode <multicode@yawk.at>
Co-Authored-By: multicode <multicode@yawk.at>
Co-Authored-By: multicode <multicode@yawk.at>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
Pull request overview
Adds Linux riscv64 support for Temurin by updating architecture validation, documentation, tests, metadata, and the bundled runtime.
Changes:
- Adds canonical
riscv64support for Temurin on Linux. - Updates compatibility documentation and action metadata.
- Adds coverage for normalization, validation, and Adoptium pass-through.
File summaries
| File | Description |
|---|---|
src/distributions/platform-types.ts |
Adds canonical and Temurin Linux riscv64 support. |
README.md |
Documents riscv64 as a canonical architecture. |
docs/advanced-usage.md |
Updates the compatibility matrix. |
dist/setup/index.js |
Regenerates the runtime bundle. |
action.yml |
Updates architecture input metadata. |
__tests__/java-platform-contract.test.ts |
Tests normalization and validation. |
__tests__/distributors/temurin-installer.test.ts |
Tests Adoptium architecture pass-through. |
Review details
- Files reviewed: 6/7 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Author
|
@luhenry PTAL as well, since you worked on lz4-java RISC-V support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Add
riscv64as a canonical architecture and allow Temurin distributions to use it on Linux.setup-javav5 forwarded the runner architecture to Adoptium and successfully installed Temurin on RISC-V. The centralized platform validation added in v6 currently rejects the same configuration before reaching the Temurin catalog, even though Adoptium publishes Linuxriscv64JDK and JRE artifacts.This change:
riscv64to the canonical architecture contract;dist/setup/index.js.Related issue:
yawkat/lz4-java#87
Check list:
npm run checklocally (format, lint, build, test) and all checks pass.