fix(label-in-name): remove SC-failing inapplicable examples - #2443
Open
WilcoFiers wants to merge 1 commit into
Open
fix(label-in-name): remove SC-failing inapplicable examples#2443WilcoFiers wants to merge 1 commit into
WilcoFiers wants to merge 1 commit into
Conversation
Removed inapplicable examples regarding abbreviations and non-standard terms from the document.
✅ Deploy Preview for act-rules ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dan-tripp-siteimprove
approved these changes
Sep 3, 2026
HelenBurge
approved these changes
Sep 3, 2026
HelenBurge
left a comment
HelenBurge
left a comment
Collaborator
There was a problem hiding this comment.
This one is interesting as I know the use of ABBR is not supported by mobile screen readers, but agree this is not inapplicable.
kengdoj
requested changes
Sep 3, 2026
kengdoj
left a comment
kengdoj
left a comment
Collaborator
There was a problem hiding this comment.
Because these are inapplicable for the rule, I added an explanation as to why they are not included on line 53.
|
|
||
| The understanding document of [2.5.3 Label in Name][understand253] use the term "symbolic text characters" to refer to a type of [non-text content][] that uses text characters as symbols, such as using "x" to mean "close". This rule considers them as "characters expressing non-text content". Unicode emojis are another example of characters expressing non-text content, although these are not "symbolic text characters". | ||
|
|
||
| If the target element contains an [image of text](https://www.w3.org/TR/WCAG22/#dfn-images-of-text), it may pass this rule but fail [2.5.3 Label in Name][understand253] (because the accessible name should then match the text inside the image, which is not taken into account by this rule). So further testing is needed. This case might be handled by a different rule in the future. |
Collaborator
There was a problem hiding this comment.
Suggested change
| If the target element contains an [image of text](https://www.w3.org/TR/WCAG22/#dfn-images-of-text), it may pass this rule but fail [2.5.3 Label in Name][understand253] (because the accessible name should then match the text inside the image, which is not taken into account by this rule). So further testing is needed. This case might be handled by a different rule in the future. | |
| This rule does not include examples of abbreviations or differently hyphenated text because the label in name algorithm should not be used. While such examples are not covered by this rule, [Success Criterion 2.5.3 Label in Name][sc253] could apply. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed inapplicable examples regarding abbreviations and non-standard terms from the document. These two may be inapplicable to the rule, but IMO they fail the success criterion. There is are no exceptions for abbreviations in this WCAG criterion. By having these as inapplicable examples we prohibit implementors from failing these.
Need for Call for Review: 1 week
How to Review And Approve