Normalize relation case when combining license expressions - #135
Open
codewithfourtix wants to merge 1 commit into
Open
Normalize relation case when combining license expressions#135codewithfourtix wants to merge 1 commit into
codewithfourtix wants to merge 1 commit into
Conversation
Signed-off-by: Ali Zulfiqar <codewithfourtix@gmail.com>
There was a problem hiding this comment.
🟢 Approval recommended
The fix aligns lookup normalization with existing validation logic and is covered by a focused regression test.
Pull request overview
Fixes a bug in combine_expressions where lowercase or mixed-case relation values (e.g., "and", "Or") would pass validation but fail during operator lookup, and adds tests to ensure case-insensitive relations are accepted.
Changes:
- Normalize
relationto uppercase during the operator lookup incombine_expressions. - Add test coverage for
and/orrelations across lowercase, uppercase, and mixed-case inputs.
File summaries
| File | Description |
|---|---|
| src/license_expression/init.py | Uppercases relation during AND/OR operator mapping to prevent KeyError for non-uppercase inputs. |
| tests/test_license_expression.py | Adds a regression test ensuring combine_expressions accepts case-insensitive "and"/"or" relations. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lowercase and mixed-case relations pass validation but then raise
KeyErrorduring operator lookup. Normalize the lookup the same way as validation.Adds coverage for
andandorin lowercase, uppercase, and mixed case.