Use CocoaPods source tags without changing package versions - #207
Open
codewithfourtix wants to merge 2 commits into
Open
Use CocoaPods source tags without changing package versions#207codewithfourtix wants to merge 2 commits into
codewithfourtix wants to merge 2 commits into
Conversation
Signed-off-by: Ali Zulfiqar <codewithfourtix@gmail.com>
There was a problem hiding this comment.
🟢 Approval recommended
The implementation correctly separates the podspec source tag from the CocoaPods package version and includes targeted tests for the intended cases.
Pull request overview
This PR updates CocoaPods package construction so that GitHub archive download URLs use the podspec’s declared source.tag (including non-v-prefixed tags), while keeping the CocoaPods package version unchanged.
Changes:
- Use
source["tag"](when present) to build GitHubarchive/refs/tags/...URLs, falling back to the CocoaPods version tag when omitted. - Add parametrized tests covering
v-prefixed tags, custom tags, and missingsource.tag.
File summaries
| File | Description |
|---|---|
src/fetchcode/package_util.py |
Uses podspec source.tag for GitHub archive URL construction without altering the package version. |
tests/test_cocoapods_source_tags.py |
Adds coverage to ensure version preservation and correct download URL tag selection. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Ali Zulfiqar <codewithfourtix@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the podspec's source tag when constructing GitHub archive URLs, including tags without a
vprefix. Keep that tag separate from the CocoaPods package version.Adds tests for prefixed, custom, and omitted source tags.