Preserve prerelease suffixes when normalizing GitHub tags - #205
Open
codewithfourtix wants to merge 2 commits into
Open
Preserve prerelease suffixes when normalizing GitHub tags#205codewithfourtix wants to merge 2 commits into
codewithfourtix wants to merge 2 commits into
Conversation
Signed-off-by: Ali Zulfiqar <codewithfourtix@gmail.com>
There was a problem hiding this comment.
🟡 Changes recommended
There are correctness/convention issues to address (robust + splitting/prefix handling in normalization and missing standard test-file license header).
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates GitHub tag normalization so it strips only a leading v/V prefix (without damaging prerelease suffixes) and correctly applies underscore-to-dot normalization even when build metadata (+...) is present, while keeping archive download URLs based on the original tag.
Changes:
- Fix tag normalization to avoid stripping trailing
vcharacters from prerelease suffixes (e.g.,v1.2-dev). - Ensure underscore normalization is applied to the version portion even when build metadata is present (e.g.,
v1_2_3+build_4→1.2.3+build_4). - Add regression tests verifying normalized version output and that archive URLs retain the original tag.
File summaries
| File | Description |
|---|---|
| tests/test_github_tag_versions.py | Adds tests covering prerelease suffix preservation, build metadata handling, and original-tag archive URLs. |
| src/fetchcode/package_util.py | Adjusts GitHub tag-to-version normalization logic to preserve suffixes and apply underscore normalization correctly. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Ali Zulfiqar <codewithfourtix@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag normalization strips trailing
vcharacters, turningv1.2-devinto1.2-de. It also discards the underscore replacement when build metadata is present. Strip the prefix only and retain the normalized version component.Tests cover both cases and verify that archive URLs retain the original tag.