Repository navigation
fix: reject invalid REST boolean query values - #1383
Merged
mykytanetipa merged 3 commits intoOct 27, 2026
Merged
mykytanetipa merged 3 commits into
mykytanetipa merged 3 commits into
Conversation
🧪 Code Coverage (vs
|
| Base | PR | Delta | |
|---|---|---|---|
| src/a2a/server/events/event_queue_v2.py | 91.79% | 92.27% | 🟢 +0.48% |
| src/a2a/utils/proto_utils.py | 95.78% | 95.85% | 🟢 +0.07% |
| src/a2a/utils/telemetry.py | 90.70% | 91.47% | 🟢 +0.78% |
| Total | 93.10% | 93.12% | 🟢 +0.02% |
Generated by coverage-comment.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GET /tasks?includeArtifacts=garbagecurrently returns 200 and treats the value asfalse, silently omitting artifacts. Reject unrecognized boolean query values with the existing400 INVALID_ARGUMENTresponse before calling the request handler.Preserve case-insensitive
true/falseparsing, the omitted-parameter default, and last-value-wins behavior. Regression tests cover public REST requests and parameter parsing, including malformed values, artifact responses, and error messages that do not echo the supplied value.Validation:
./scripts/lint.shThe local full-suite and coverage runs used a temporary helper that continuously drains the cross-version fixture servers' output to avoid blocked pipes. The fixture assertions and timeouts were unchanged.