Repository navigation
fix(server): include legacy task states in database list filters - #1337
Merged
mykytanetipa merged 2 commits intoOct 24, 2026
Merged
Conversation
🧪 Code Coverage (vs
|
| Base | PR | Delta | |
|---|---|---|---|
| src/a2a/server/tasks/database_task_store.py | 95.16% | 95.70% | 🟢 +0.54% |
| Total | 92.98% | 92.99% | 🟢 +0.01% |
Generated by coverage-comment.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
description
DatabaseTaskStorecan read v0.3 task rows, but its status filter compares their JSON state only with the 1.0 protobuf enum name. A legacy working task is readable withGetTaskyet missing fromListTasks(status=WORKING), with an incorrect total.Match both spellings using the existing compatibility converter. The filter stays in SQL before counting and pagination, with owner scoping unchanged. No schema change is needed.
The regression covers all eight concrete states, mixed modern and legacy rows, missing legacy protocol versions, owner isolation and page tokens. All eight SQLite cases failed before the fix.
validation
Rebased onto main at
799fcae. Fresh checks on that base:UV_PYTHON=3.10 ./scripts/lint.shpassed Ruff, formatting and ty.UV_PYTHON=3.10 uv run pytest --timeout=45: 2,277 passed, 199 skipped, 3 xfailed, 1 xpassed.UV_PYTHON=3.10 uv run pytest --timeout=45 --cov=src --cov-report=term-missing --cov-fail-under=88: same test results, 93.29% coverage.PostgreSQL/MySQL service tests skipped because their DSNs were unset. The new regressions ran on SQLite. Existing xfail/xpass cases reference #869.
CONTRIBUTINGGuide.