fix(server): reconcile blocking result with TaskStore#991
Open
jstar0 wants to merge 4 commits into
Open
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Collaborator
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Keep the existing four-argument constructor delegating to the original one-second reconciliation timeout, and cover the new configuration wiring and default value. This fixes #2049
Author
|
Thanks @kabir. I integrated your configurable timeout and debug logging commit, then added coverage for the configuration wiring and default value. The focused 46-test run and the complete |
kabir
requested changes
Jul 23, 2026
kabir
left a comment
Collaborator
There was a problem hiding this comment.
I don't se the need for the re-introduced constructor. Assuming I'm not mistaken, please get rid of it.
The additional tests look good though 👍
ehsavoie
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a race in the blocking Java server response path tracked by a2aproject/A2A#2049.
onMessageSendcan currently return an internal error when the agent is complete but TaskStore persistence is still becoming visible to the response aggregator.Root Cause / Context
When the event consumer completes without delivering a Message or full Task event,
ResultAggregatorperforms one TaskStore lookup and immediately raisesCould not find a Task/Messageif the row is not visible yet. That prevents the later response-handler TaskStore reconciliation from running.Changes
a2a.blocking.reconciliation.timeout.seconds, retaining the existing one-second behavior by default.Scope / Risk
Only the blocking empty-capture path polls TaskStore, and the default timeout remains one second. EventConsumer lifecycle, TaskStore APIs, cancellation, streaming emission, and the public A2A protocol are unchanged.
Verification
The module suites pass 416
server-commontests and 10 MicroProfile config tests. The focused cross-module run passes 46 tests.Fixes a2aproject/A2A#2049