Repository navigation
Fix Linux AppImage for AppImageHub and Ubuntu 24.04, add engine check switch - #32
Merged
Merged
Conversation
Build Linux artifacts with mksquashfs' zlib default so AppImageHub's mount helper can read them, and add a launcher that only falls back to --no-sandbox inside an AppImage when unprivileged user namespaces are restricted. The .deb keeps its root-owned sandbox helper.
The check and its toast already existed but always ran. Make it explicit in Settings and skip the GitHub request when disabled; it still never installs a newer engine without confirmation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Build Linux artifacts with mksquashfs' zlib default instead of xz, add a launcher that falls back to
--no-sandboxonly inside an AppImage when unprivileged user namespaces are restricted, and add a Settings switch for the launch ipatool update check.Why
AppImageHub's mount helper rejects the xz-compressed SquashFS produced by
compression: maximum, so the catalog submission for v0.3.0 failed. Ubuntu 24.04 also aborts the AppImage before the first window because its AppArmor policy blocks unprivileged user namespaces and the AppImage's SUID sandbox helper cannot be root-owned (issue #31). The engine update check already runs on launch and shows a toast; the new setting makes that GitHub request optional.How it was verified
npm run typecheck,npx eslint src tests scripts,npx vitest run(33 files, 494 passed, 2 skipped),npm run build..binlayout.Not verified
Checklist
npm run typecheckpassesnpm testpasses (coverage gate included)npm run lintpassessrc/shared/has tests