Skip to content

fix(msp430): correct memset and memcpy assembly operand order for TI … #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
by965738071 wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −5
Open

fix(msp430): correct memset and memcpy assembly operand order for TI … #981

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions core/src/cpus/msp430.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,15 +136,15 @@ export fn memset(dest: [*]u8, ch: u8, count: usize) callconv(.c) [*]u8 {
_ = count; // R14
asm volatile (
\\ MOV R12, R5
\\ ADD R5, R14
\\ ADD R14, R5
\\memset_loop:
\\ CMP R5, R12
\\ JEQ memset_done
\\ MOV.B R13, @R12
\\ INC R12
\\ JMP memset_loop
\\memset_done:
\\ SUB R12, R14
\\ SUB R14, R12
::: .{
.r5 = true,
// r12 doesn't go in the clobbers because it is restored before exiting
Expand All @@ -160,16 +160,16 @@ export fn memcpy(dest: [*]u8, src: [*]const u8, count: usize) callconv(.c) [*]u8
_ = src; // R13
_ = count; // R14
asm volatile (
\\ MOV R5, R12
\\ ADD R5, R14
\\ MOV R12, R5
\\ ADD R14, R5
\\memcpy_loop:
\\ CMP R5, R12
\\ JEQ memcpy_done
\\ MOV.B @R13, @R12
\\ INC R12
\\ INC R13
\\memcpy_done:
\\ SUB R12, R14
\\ SUB R14, R12
::: .{
.r5 = true,
// r12 doesn't go in the clobbers because it is restored before exiting
Expand Down
Loading