Repository navigation
Conversation
Grazfather
left a comment
There was a problem hiding this comment.
mostly looks good, will want to take another look, but: If we are assigning This() to a name, let's use that name
|
I tested these changes on pico 2, but not on nrf5x or ch32v, testing those platforms would be appreciated! |
|
@piotrfila I have an nrf5, and a ch32v, I'm on a trip right now, but I'll give those a test by Tuesday! |
Grazfather
left a comment
There was a problem hiding this comment.
Looks good, some pedantic issues. A lot of unrelated changes I'd prefer to merge separately, but nbd.
|
|
||
| const pin_config: rp2xxx.pins.GlobalConfiguration = .{ | ||
| .GPIO25 = .{ .name = "led", .direction = .out }, | ||
| }; |
There was a problem hiding this comment.
Why not just pull these from the board file?
| pub const ack: []const u8 = ""; | ||
| pub const nak: ?[]const u8 = null; | ||
|
|
||
| // What does this do? It lets you iterate through interfaces and endpoints? |
There was a problem hiding this comment.
lmao. This is an old comment I wrote while trying to grok our USB stuff. Never intended to be committed.
| const zenkakuhankaku: @This() = .lang5; | ||
| }; | ||
|
|
||
| pub const Ledcode = enum(u3) { |
There was a problem hiding this comment.
should this be LedCode?
There was a problem hiding this comment.
Keycode does not have C capitalized, having Keycode but LedCode seemed inconsistent, this was the variant I liked most out of:
- KeyCode, LedCode
- Keycode, LedCode
- Keycode, Ledcode
but first variant is also ok imo
Based on talks on discord with @vesim987
This should make some drivers (such as HID and MIDI) more ergonomic.
Major changes: