Repository navigation
Re-pin rust-lightning to v0.2.7 + Zeus patches - #8
Merged
Merged
Conversation
This was referenced Oct 2, 2026
Merged
Merged
Move the fork off the stale lsps7-for-ldk-node-close-fix branch (a Dec 2025 snapshot of upstream main missing every 0.2.1-0.2.5 fix, including the 0.2.3 'Through the Loupe' and 0.2.5 'MegaScan' security batches) onto ZeusLN/rust-lightning zeus-0.2, which is upstream 0.2 branch head (= v0.2.5) plus the same five Zeus patches: - LSPS7 (Channel Lease Extensions) client handler - cooperative close feerate floor bypass - BOLT11 route hints override (+ tests) Since v0.2.5 predates upstream #4175 (impl-Future trait methods), this also reverts 84bf2a5 ("Update to new upstream rust-lightning with impl Futures") and adapts the pieces written after it: - DualStore's async KVStore impl returns boxed futures again - builder passes Arc-wrapped DualStore to build_with_store - test helpers updated for LDK 0.2.5 test API (check_closed_event is_check_discard_funding arg) and the fork's 3-arg bolt11 send The pre-existing integration-test compile breakage (bolt11 send call sites in tests/ and benches/, present since the retry-timeout param was added) is untouched except where the revert crossed it.
Move the rust-lightning pin from zeus-0.2 (v0.2.5) to ZeusLN/rust-lightning 4e5cba988, which is upstream v0.2.7 plus the same five Zeus patches carried on zeus-0.2 (LSPS7 client, cooperative close feerate floor bypass, BOLT11 route hints override + tests, LSPS5 test config fix). The patch contents are unchanged; only hunk context moved in the rebase. Pin by rev instead of branch so the lockfile can't drift if the branch is rebased. This picks up the 0.2.6 and 0.2.7 security fixes, including: - conflicting commitment signed at the same index after a peer fakes a lost revoke_and_ack on reconnect (#5057) - unbroadcastable commitment accepted on inbound channels (#4976) - LSPS2 intercepted HTLC amount not checked before JIT open (#5042) - Electrum sync amplification via crafted funding tx (#4867) - bogus-HTLC rejection leaving an undeserializable ChannelManager (#4982) No API changes affect ldk-node; cargo check --all-targets is clean.
kaloudis
force-pushed
the
rl-0.2.7-security-bump
branch
from
October 3, 2026 00:20
5f4194f to
6e0f337
Compare
kaloudis
added a commit
to kaloudis/zeus
that referenced
this pull request
Oct 3, 2026
The release was rebuilt from the merged ZeusLN/ldk-node#8 commit (4687d9f) instead of the pre-merge branch head, so both asset hashes changed. Same rust-lightning pin (4e5cba988).
kaloudis
added a commit
to ZeusLN/zeus
that referenced
this pull request
Oct 5, 2026
…y fixes) Moves the embedded LDK Node build from rust-lightning v0.2.5 to v0.2.7, which picks up the 0.2.6 and 0.2.7 security releases. Same Zeus patch set as before. Fork changes: ZeusLN/ldk-node#8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #5. This branch contains #5's three commits plus the 0.2.7 re-pin, so merging this one merges both.
Re-pins rust-lightning to ZeusLN/rust-lightning
4e5cba988(anchored by branchzeus-0.2.7-ldk-node): upstream v0.2.7 plus the same five Zeus patches aszeus-0.2(LSPS7 client, cooperative close feerate floor bypass, BOLT11 route hints override + tests, LSPS5 test config).git range-diffagainst the 0.2.5 set shows only moved hunk context, no content changes. The pin is now byrevinstead ofbranch.This deliberately excludes the two reestablish / remote-signer commits on
zeus-0.2.7(963be1655,4371384d3). Those were added for VLS and are not needed with the in-process KeysManager.Picks up the 0.2.6 and 0.2.7 security fixes, including:
Testing:
4e5cba988:lightninglib 1219 passed (9 ignored),lightning-liquidity102 passedcargo check --all-targetsclean,cargo test --lib23/234e5cba9Not run: integration tests (bitcoind/electrs), device testing.
Release:
v0.7.0-zeus-rl-0.2.7(pre-release)