deps: bump AWSSDK.S3 to 4.0.102.4 (+ fix the v4 pagination break) - #54
Merged
Conversation
…roduces
The v4 major cannot be taken as a version bump alone: ListObjectsV2Response.
IsTruncated is now bool? rather than bool, so the S3 import loop no longer
compiles ("Operator '&&' cannot be applied to operands of type 'bool?' and
'bool'"), which is why Dependabot's PR could not build.
Compare against an explicit true. Unset means the response never claimed there
was more to fetch, so anything else ends pagination rather than looping.
Supersedes #48, which is the same bump without the code change.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #48, which is the same bump without the code change it needs.
What & why
AWS SDK v4 is a major, and it cannot be taken as a version bump alone.
ListObjectsV2Response.IsTruncatedchanged frombooltobool?, so the S3 import loop stops compiling:That's why #48 could not build. Fixed by comparing against an explicit
true:Unset means the response never claimed there was more to fetch, so anything other than
trueends pagination — the safe reading, and the one that can't loop forever.AWSSDK.S3is used in exactly one place,ImportedDocsPlugin, for pulling docs out of a bucket. Thes3deploy target shells out to the AWS CLI and is untouched by this.Type of change
Checklist
dotnet format Netdocs.slnx --verify-no-changespassesdotnet build Netdocs.slnx -c Releasesucceedsdotnet test Netdocs.slnx -c Releasepasses (512)docs-site/docs/**— no user-facing behaviour changeNotes for reviewers
Worth knowing before merging: the S3 import path has no runtime test coverage, before or after this change. The nine
ImportedDocsPluginTestscover config objects only — none construct anAmazonS3Clientor exercise a list/get call. So this upgrade is compile-verified and green across the suite, but the actual pagination against a live bucket is not exercised by CI, and I have no bucket to try it against.The change itself is the standard v4 migration for this property and is hard to get wrong in a way that compiles. But if you have a bucket handy, one
imported-docspull with more than 1000 objects (the point where pagination actually kicks in) would put it beyond doubt.🤖 Generated with Claude Code