rfdc: fall back to config struct when tile/block/path enable register… - #387
Draft
ivan-at-ericsson wants to merge 1 commit into
Draft
Conversation
…s read 0Older RFdc IP generations (Gen1 XCZU27DR) do not populate theTILES_ENABLED (0x00A0), ADC_PATHS_ENABLED (0x00A4) andDAC_PATHS_ENABLED (0x00A8) registers, so they read 0. Since ~2019the driver derives tile/block/digital-path availability solely fromthese registers, causing every tile/block to be reported as notavailable on such designs even though the converters exist and run.This restores the pre-2019 behaviour as a fallback: when the registerreads 0, availability is derived from the config structure instead.The fallback is never reached on modern hardware where the registersare properly populated, so there is no behavioural change for Gen3+.Signed-off-by: Ivan Bakusic ivan.bakusic@ericsson.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s read 0Older RFdc IP generations (Gen1 XCZU27DR) do not populate theTILES_ENABLED (0x00A0), ADC_PATHS_ENABLED (0x00A4) andDAC_PATHS_ENABLED (0x00A8) registers, so they read 0. Since ~2019the driver derives tile/block/digital-path availability solely fromthese registers, causing every tile/block to be reported as notavailable on such designs even though the converters exist and run.This restores the pre-2019 behaviour as a fallback: when the registerreads 0, availability is derived from the config structure instead.The fallback is never reached on modern hardware where the registersare properly populated, so there is no behavioural change for Gen3+.Signed-off-by: Ivan Bakusic ivan.bakusic@ericsson.com