fix(accounting): accept delivery contact addresses - #842
Open
miachillgood wants to merge 1 commit into
Open
miachillgood wants to merge 1 commit into
miachillgood wants to merge 1 commit into
Conversation
BREAKING CHANGE: Generated clients gain DELIVERY in the contact address type enum.
miachillgood
force-pushed
the
codex/issue-666-contact-delivery-address
branch
from
September 26, 2026 04:54
3afb58d to
c3101e0
Compare
Author
|
I updated the branch onto the latest The OpenAPI Spec Diff Check and PR Linting workflows currently show |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The live Accounting API can return
DELIVERYinContact.Addresses[].AddressType, while the reusableAddressschema only permitsPOBOXandSTREET. Generated SDKs with closed enums therefore fail to deserialize the entire contact.AddressForOrganisationalready includesDELIVERY; this aligns the contact address schema with the observed response and prevents the generated client failure reported in XeroAPI/Xero-NetStandard#666.The commit uses the repository's Conventional Commits breaking marker because adding a response enum value requires regenerated clients to expose the expanded enum.
Fixes XeroAPI/Xero-NetStandard#666.
Validation
xero_accounting.yamlsuccessfullyscripts/api-diff/api-diff.test.sh(9/9 passed)git diff --checkRepository CI will run the official API diff and code-generation validation.