Skip to content

Implement XMLTOCURSOR() - #2070

Open
Irwin1985 wants to merge 2 commits into
devfrom
feature/vfp-xmltocursor
Open

Implement XMLTOCURSOR()#2070
Irwin1985 wants to merge 2 commits into
devfrom
feature/vfp-xmltocursor

Conversation

@Irwin1985

Copy link
Copy Markdown
Contributor

Implements XMLTOCURSOR().

The data is always read with XmlReadMode.InferSchema which hands every column over as a string and the inline XSD is read separately with XPath.

@RobertvanderHulst

Copy link
Copy Markdown
Member

A small styling comment: I personally do not like the long list of functions that start with __FoxXml.
I understand that you choose the prefix to group them together.
Our Functions classes are already very full with methods and defines. Since this is an internal implementation I would like to move this to a separate class. I have done something similar for the OOPHelpers class in XSharp.RT.
So I suggest that create an (internal) class FoxXml or something similar and make these all methods of the same class. That way they are grouped together. You can also add the defines as constants to the class.

@Irwin1985

Copy link
Copy Markdown
Contributor Author

Robert, my fault. I remember you told me this before. I'll create a note in my desktop to memorize it because I do use this convention in daily work.

I'll do the refactor ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants