[VsIntegration] Fix reference resolution: marshal AddPendingReference… - #2066
Merged
RobertvanderHulst merged 1 commit intoAug 22, 2026
Merged
Conversation
…s onto the UI thread
RobertvanderHulst
deleted the
fix/sdkprojectnode-addpendingreferences-ui-thread
branch
August 22, 2026 14:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XSharpSdkProjectNode.AddPendingReferences disposes an AssemblyReferenceNode, which requires the UI thread, but is called from ProjectFinishedHandler (an MSBuild logger callback that runs on a background thread).
This threw a COMException that was silently swallowed by the caller's own try/catch, so RefreshReferencesFromResponseFile() never ran and NuGet-sourced 3rd-party references never got picked up after a build.