Skip to content

Fix SYSMETRIC() by going through GetSystemMetrics() #2065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobertvanderHulst merged 1 commit into from
Aug 22, 2026
+72 −40
Merged

Fix SYSMETRIC() by going through GetSystemMetrics() #2065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 34 additions & 40 deletions src/Runtime/XSharp.VFP.UI/VfpUIProvider.prg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,46 +54,40 @@ BEGIN NAMESPACE XSharp.VFP.UI

PUBLIC METHOD SysMetric(nScreenElement AS LONG) AS LONG
SWITCH nScreenElement
CASE 1 // SYSMETRIC_SCREENWIDTH
LOCAL hDC := VfpWin32UI.GetDC(IntPtr.Zero) AS IntPtr
LOCAL nRes := VfpWin32UI.GetDeviceCaps(hDC, VfpWin32UI.DESKTOP_HORZRES) AS LONG
VfpWin32UI.ReleaseDC(IntPtr.Zero, hDC)
RETURN nRes
CASE 2 // SYSMETRIC_SCREENHEIGHT
LOCAL hDC := VfpWin32UI.GetDC(IntPtr.Zero) AS IntPtr
LOCAL nRes := VfpWin32UI.GetDeviceCaps(hDC, VfpWin32UI.DESKTOP_VERTRES) AS LONG
VfpWin32UI.ReleaseDC(IntPtr.Zero, hDC)
RETURN nRes
CASE 3; RETURN SystemInformation.MinimizedWindowSpacingSize.Width
CASE 4; RETURN SystemInformation.MinimizedWindowSpacingSize.Height
CASE 5; RETURN SystemInformation.VerticalScrollBarWidth
CASE 6; RETURN SystemInformation.VerticalScrollBarArrowHeight
CASE 7; RETURN SystemInformation.HorizontalScrollBarArrowWidth
CASE 8; RETURN SystemInformation.HorizontalScrollBarHeight
CASE 9; RETURN SystemInformation.CaptionHeight
CASE 10; RETURN SystemInformation.FixedFrameBorderSize.Width
CASE 11; RETURN SystemInformation.FixedFrameBorderSize.Height
CASE 12; RETURN SystemInformation.FrameBorderSize.Width
CASE 13; RETURN SystemInformation.FrameBorderSize.Height
CASE 14; RETURN SystemInformation.HorizontalScrollBarThumbWidth
CASE 15; RETURN SystemInformation.VerticalScrollBarWidth
CASE 16; RETURN SystemInformation.IconSize.Width
CASE 17; RETURN SystemInformation.IconSize.Height
CASE 18; RETURN 0
CASE 19; RETURN 0
CASE 20; RETURN SystemInformation.MenuHeight
CASE 21; RETURN SystemInformation.MaxWindowTrackSize.Width
CASE 22; RETURN SystemInformation.MaxWindowTrackSize.Height
CASE 23; RETURN SystemInformation.KanjiWindowHeight
CASE 24; RETURN SystemInformation.MinWindowTrackSize.Width
CASE 25; RETURN SystemInformation.MinWindowTrackSize.Height
CASE 26; RETURN SystemInformation.MinimumWindowSize.Width
CASE 27; RETURN SystemInformation.MinimumWindowSize.Height
CASE 30; RETURN iif(SystemInformation.MousePresent == TRUE, 1, 0)
CASE 31; RETURN iif(SystemInformation.DebugOS == TRUE , 1, 0)
CASE 32; RETURN iif(SystemInformation.MouseButtonsSwapped == TRUE, 1, 0)
CASE 33; RETURN SystemInformation.ToolWindowCaptionButtonSize.Width
CASE 34; RETURN SystemInformation.ToolWindowCaptionHeight
CASE 1; RETURN VfpWin32UI.GetSystemMetrics(VfpWin32UI.SM_CXSCREEN)
CASE 2; RETURN VfpWin32UI.GetSystemMetrics(VfpWin32UI.SM_CYSCREEN)
CASE 3; RETURN SystemInformation.MinimizedWindowSpacingSize.Width
CASE 4; RETURN SystemInformation.MinimizedWindowSpacingSize.Height
CASE 5; RETURN VfpWin32UI.GetSystemMetrics(VfpWin32UI.SM_CXVSCROLL)
CASE 6; RETURN VfpWin32UI.GetSystemMetrics(VfpWin32UI.SM_CYVSCROLL)
CASE 7; RETURN VfpWin32UI.GetSystemMetrics(VfpWin32UI.SM_CXHSCROLL)
CASE 8; RETURN VfpWin32UI.GetSystemMetrics(VfpWin32UI.SM_CYHSCROLL)
CASE 9; RETURN VfpWin32UI.GetSystemMetrics(VfpWin32UI.SM_CYCAPTION)
CASE 10; RETURN VfpWin32UI.GetSystemMetrics(VfpWin32UI.SM_CXBORDER)
CASE 11; RETURN VfpWin32UI.GetSystemMetrics(VfpWin32UI.SM_CYBORDER)
CASE 12; RETURN VfpWin32UI.GetSystemMetrics(VfpWin32UI.SM_CXDLGFRAME)
CASE 13; RETURN VfpWin32UI.GetSystemMetrics(VfpWin32UI.SM_CYDLGFRAME)
CASE 14; RETURN VfpWin32UI.GetSystemMetrics(VfpWin32UI.SM_CXHTHUMB)
CASE 15; RETURN VfpWin32UI.GetSystemMetrics(VfpWin32UI.SM_CYVTHUMB)
CASE 16; RETURN VfpWin32UI.GetSystemMetrics(VfpWin32UI.SM_CXICON)
CASE 17; RETURN VfpWin32UI.GetSystemMetrics(VfpWin32UI.SM_CYICON)
CASE 18; RETURN VfpWin32UI.GetSystemMetrics(VfpWin32UI.SM_CXCURSOR)
CASE 19; RETURN VfpWin32UI.GetSystemMetrics(VfpWin32UI.SM_CYCURSOR)
CASE 20; RETURN VfpWin32UI.GetSystemMetrics(VfpWin32UI.SM_CYMENU)
CASE 21; RETURN VfpWin32UI.GetSystemMetrics(VfpWin32UI.SM_CXFULLSCREEN)
CASE 22; RETURN VfpWin32UI.GetSystemMetrics(VfpWin32UI.SM_CYFULLSCREEN)
CASE 23; RETURN VfpWin32UI.GetSystemMetrics(VfpWin32UI.SM_CYKANJIWINDOW)
CASE 24; RETURN VfpWin32UI.GetSystemMetrics(VfpWin32UI.SM_CXMINTRACK)
CASE 25; RETURN VfpWin32UI.GetSystemMetrics(VfpWin32UI.SM_CYMINTRACK)
CASE 26; RETURN VfpWin32UI.GetSystemMetrics(VfpWin32UI.SM_CXMIN)
CASE 27; RETURN VfpWin32UI.GetSystemMetrics(VfpWin32UI.SM_CYMIN)
CASE 28; RETURN VfpWin32UI.GetSystemMetrics(VfpWin32UI.SM_CXSIZE)
CASE 29; RETURN VfpWin32UI.GetSystemMetrics(VfpWin32UI.SM_CYSIZE)
CASE 30; RETURN IIF(VfpWin32UI.GetSystemMetrics(VfpWin32UI.SM_MOUSEPRESENT) != 0, 1, 0)
CASE 31; RETURN IIF(VfpWin32UI.GetSystemMetrics(VfpWin32UI.SM_DEBUG) != 0, 1, 0)
CASE 32; RETURN IIF(VfpWin32UI.GetSystemMetrics(VfpWin32UI.SM_SWAPBUTTON) != 0, 1, 0)
CASE 33; RETURN VfpWin32UI.GetSystemMetrics(VfpWin32UI.SM_CXSMSIZE)
CASE 34; RETURN VfpWin32UI.GetSystemMetrics(VfpWin32UI.SM_CYSMSIZE)
END SWITCH
RETURN 0
END METHOD
Expand Down
38 changes: 38 additions & 0 deletions src/Runtime/XSharp.VFP.UI/Win32UI.prg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,41 @@ BEGIN NAMESPACE XSharp.VFP.UI
PUBLIC CONST DESKTOP_HORZRES := 117 AS INT
PUBLIC CONST DESKTOP_VERTRES := 118 AS INT
PUBLIC CONST PD_PRINTSETUP := 0x40U AS DWORD

// SYSMETRIC(): the VFP help points at GetSystemMetrics()
PUBLIC CONST SM_CXSCREEN := 0 AS INT
PUBLIC CONST SM_CYSCREEN := 1 AS INT
PUBLIC CONST SM_CXVSCROLL := 2 AS INT
PUBLIC CONST SM_CYHSCROLL := 3 AS INT
PUBLIC CONST SM_CYCAPTION := 4 AS INT
PUBLIC CONST SM_CXBORDER := 5 AS INT
PUBLIC CONST SM_CYBORDER := 6 AS INT
PUBLIC CONST SM_CXDLGFRAME := 7 AS INT
PUBLIC CONST SM_CYDLGFRAME := 8 AS INT
PUBLIC CONST SM_CYVTHUMB := 9 AS INT
PUBLIC CONST SM_CXHTHUMB := 10 AS INT
PUBLIC CONST SM_CXICON := 11 AS INT
PUBLIC CONST SM_CYICON := 12 AS INT
PUBLIC CONST SM_CXCURSOR := 13 AS INT
PUBLIC CONST SM_CYCURSOR := 14 AS INT
PUBLIC CONST SM_CYMENU := 15 AS INT
PUBLIC CONST SM_CXFULLSCREEN := 16 AS INT
PUBLIC CONST SM_CYFULLSCREEN := 17 AS INT
PUBLIC CONST SM_CYKANJIWINDOW := 18 AS INT
PUBLIC CONST SM_MOUSEPRESENT := 19 AS INT
PUBLIC CONST SM_CYVSCROLL := 20 AS INT
PUBLIC CONST SM_CXHSCROLL := 21 AS INT
PUBLIC CONST SM_DEBUG := 22 AS INT
PUBLIC CONST SM_SWAPBUTTON := 23 AS INT
PUBLIC CONST SM_CXMIN := 28 AS INT
PUBLIC CONST SM_CYMIN := 29 AS INT
PUBLIC CONST SM_CXSIZE := 30 AS INT
PUBLIC CONST SM_CYSIZE := 31 AS INT
PUBLIC CONST SM_CXMINTRACK := 34 AS INT
PUBLIC CONST SM_CYMINTRACK := 35 AS INT
PUBLIC CONST SM_CXSMSIZE := 52 AS INT
PUBLIC CONST SM_CYSMSIZE := 53 AS INT

[StructLayout(LayoutKind.Sequential, CharSet := CharSet.Unicode)];
PUBLIC STRUCT PRINTDLGW
PUBLIC lStructSize AS DWORD
Expand Down Expand Up @@ -84,6 +119,9 @@ BEGIN NAMESPACE XSharp.VFP.UI
[DllImport("gdi32.dll", CharSet := CharSet.Auto, SetLastError := TRUE, ExactSpelling := TRUE)];
STATIC EXTERN METHOD GetDeviceCaps(hDC AS IntPtr, nIndex AS INT) AS INT

[DllImport("user32.dll", CharSet := CharSet.Auto, SetLastError := TRUE, ExactSpelling := TRUE)];
STATIC EXTERN METHOD GetSystemMetrics(nIndex AS INT) AS INT

[DllImport("user32.dll", CharSet := CharSet.Auto, SetLastError := TRUE, ExactSpelling := TRUE)];
STATIC EXTERN METHOD GetDC(hWnd AS IntPtr) AS IntPtr

Expand Down