chore: bump TypeScript to ^6.0.0 - #51
Open
edwardweymouth-wk wants to merge 7 commits into
Open
Conversation
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 17 | ||
| node-version: 20 |
There was a problem hiding this comment.
woah, thats old, was node 20 required? did 24 have more errors than it was worth bumping to?
matthewnitschke-wk
previously approved these changes
Aug 31, 2026
matthewnitschke-wk
left a comment
matthewnitschke-wk
left a comment
There was a problem hiding this comment.
2 comments, but I'm not overly concerned about them
Comment on lines
+16
to
+17
| import * as Mocha from 'mocha'; | ||
| import * as glob from 'glob'; | ||
| import Mocha = require('mocha'); | ||
| import glob = require('glob'); |
There was a problem hiding this comment.
Fixes
src/test/suite/index.ts: changesimport * as Mocha/import * as globtoimport = requirestyle for correct CommonJS constructability
I'm not sure this is what we want to do, cjs is quite deprecated and the less ideal path
Why was this required?
Author
There was a problem hiding this comment.
oh yeh... geez that is just wrong. Missed that in the shuffle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Org-wide TypeScript v6 upgrade.
typescriptfrom^3.8.3to^6.0.0inpackage.json@typescript-eslint/eslint-pluginfrom^3.1.0to^8.65.0@typescript-eslint/parserfrom^3.1.0to^8.65.0skipLibCheck: trueandesModuleInterop: truetotsconfig.jsonsrc/extension.ts: changesNumber/Booleanwrapper types tonumber/booleanprimitives (TS6 rejects comparing wrapper types with>)src/test/suite/index.ts: usesimport Mocha from 'mocha'/import glob from 'glob'(default imports viaesModuleInterop) instead of namespace imports, which TS6 no longer allows to be used as constructorsTest plan