Skip to content

feat: Add Dark mode tokens - #4255

Draft
RayRedGoose wants to merge 3 commits into
Workday:prerelease/minorfrom
RayRedGoose:dark-mode-tokens
Draft

RayRedGoose wants to merge 3 commits into
Workday:prerelease/minorfrom
RayRedGoose:dark-mode-tokens

Conversation

@RayRedGoose

Copy link
Copy Markdown
Contributor

Summary

Fixes: #1234

Release Category

Components

Release Note

Optional release note message. Changelog and release summaries will contain a pull request title. This section will add additional notes under that title. This section is not a summary, but something extra to point out in release notes. An example might be calling out breaking changes in a labs component or minor visual changes that need visual regression updates. Remove this section if no additional release notes are required.

BREAKING CHANGES

Optional breaking changes message. If your PR includes breaking changes. It is extremely rare to put breaking changes outside a prerelease/major branch. Anything in this section will show up in release notes. Remove this section if no breaking changes are present.


Checklist

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)
  • PR Release Notes describes additional information useful to call out in a release message or removed if not applicable
  • Breaking Changes provides useful information to upgrade to this code or removed if not applicable

Where Should the Reviewer Start?

Areas for Feedback? (optional)

  • Code
  • Documentation
  • Testing
  • Codemods

Testing Manually

Screenshots or GIFs (if applicable)

Thank You Gif (optional)

@coderabbitai

coderabbitai Bot commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

theme.canvas.palette.neutral.darkest | brand.neutral.darkest | --cnvs-brand-neutral-darkest
theme.canvas.palette.neutral.contrast | brand.neutral.accent | --cnvs-brand-neutral-accent
theme.canvas.palette.common.focusOutline | brand.common.focusOutline | --cnvs-brand-common-focus-outline
theme.canvas.palette.common.focusOutline | brand.common.focus | --cnvs-brand-common-focus-outline

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
theme.canvas.palette.common.focusOutline | brand.common.focus | --cnvs-brand-common-focus-outline
theme.canvas.palette.common.focusOutline | brand.common.focus | --cnvs-brand-common-focus

theme.canvas.palette.neutral.darkest | brand.neutral.darkest | --cnvs-brand-neutral-darkest
theme.canvas.palette.neutral.contrast | brand.neutral.accent | --cnvs-brand-neutral-accent
theme.canvas.palette.common.focusOutline | brand.common.focusOutline | --cnvs-brand-common-focus-outline
theme.canvas.palette.common.focusOutline | brand.common.focusO | --cnvs-brand-common-focus-outline

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
theme.canvas.palette.common.focusOutline | brand.common.focusO | --cnvs-brand-common-focus-outline
theme.canvas.palette.common.focusOutline | brand.common.focus | --cnvs-brand-common-focus

| `theme.canvas.palette.neutral.darkest` | `brand.neutral.darkest` | `brand.neutral800` | `--cnvs-brand-neutral-800` |
| `theme.canvas.palette.neutral.contrast` | `brand.neutral.accent` | `system.color.fg.inverse` | `--cnvs-brand-fg-inverse` |
| `theme.canvas.palette.common.focusOutline` | `brand.common.focusOutline` | `brand.common.focus` | `--cnvs-brand-common-focus` |
| `theme.canvas.palette.common.focusOutline` | `brand.common.focus` | `brand.common.focus` | `--cnvs-brand-common-focus` |

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `theme.canvas.palette.common.focusOutline` | `brand.common.focus` | `brand.common.focus` | `--cnvs-brand-common-focus` |
| `theme.canvas.palette.common.focusOutline` | `brand.common.focusOutline` | `brand.common.focus` | `--cnvs-brand-common-focus` |

@cypress

cypress Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Workday/canvas-kit    Run #11833

Run Properties:  status check passed Passed #11833  •  git commit 7ae33afa86 ℹ️: Merge 5b8db564c8814f9c103460a65131a1da1298b147 into 0bad6046e17e2103e5043f4fc758...
Project Workday/canvas-kit
Branch Review dark-mode-tokens
Run status status check passed Passed #11833
Run duration 02m 59s
Commit git commit 7ae33afa86 ℹ️: Merge 5b8db564c8814f9c103460a65131a1da1298b147 into 0bad6046e17e2103e5043f4fc758...
Committer Raisa Primerova
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 17
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 940
View all changes introduced in this branch ↗︎
UI Coverage  14.61%
  Untested elements 2558  
  Tested elements 435  
Accessibility  99.58%
  Failed rules  3 critical   5 serious   3 moderate   1 minor
  Failed elements 72  

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant