Repository navigation
feat: Add Dark mode tokens - #4255
Draft
RayRedGoose wants to merge 3 commits into
Draft
RayRedGoose wants to merge 3 commits into
RayRedGoose wants to merge 3 commits into
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
RayRedGoose
commented
Nov 13, 2026
| theme.canvas.palette.neutral.darkest | brand.neutral.darkest | --cnvs-brand-neutral-darkest | ||
| theme.canvas.palette.neutral.contrast | brand.neutral.accent | --cnvs-brand-neutral-accent | ||
| theme.canvas.palette.common.focusOutline | brand.common.focusOutline | --cnvs-brand-common-focus-outline | ||
| theme.canvas.palette.common.focusOutline | brand.common.focus | --cnvs-brand-common-focus-outline |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| theme.canvas.palette.common.focusOutline | brand.common.focus | --cnvs-brand-common-focus-outline | |
| theme.canvas.palette.common.focusOutline | brand.common.focus | --cnvs-brand-common-focus |
RayRedGoose
commented
Nov 13, 2026
| theme.canvas.palette.neutral.darkest | brand.neutral.darkest | --cnvs-brand-neutral-darkest | ||
| theme.canvas.palette.neutral.contrast | brand.neutral.accent | --cnvs-brand-neutral-accent | ||
| theme.canvas.palette.common.focusOutline | brand.common.focusOutline | --cnvs-brand-common-focus-outline | ||
| theme.canvas.palette.common.focusOutline | brand.common.focusO | --cnvs-brand-common-focus-outline |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| theme.canvas.palette.common.focusOutline | brand.common.focusO | --cnvs-brand-common-focus-outline | |
| theme.canvas.palette.common.focusOutline | brand.common.focus | --cnvs-brand-common-focus |
RayRedGoose
commented
Nov 13, 2026
| | `theme.canvas.palette.neutral.darkest` | `brand.neutral.darkest` | `brand.neutral800` | `--cnvs-brand-neutral-800` | | ||
| | `theme.canvas.palette.neutral.contrast` | `brand.neutral.accent` | `system.color.fg.inverse` | `--cnvs-brand-fg-inverse` | | ||
| | `theme.canvas.palette.common.focusOutline` | `brand.common.focusOutline` | `brand.common.focus` | `--cnvs-brand-common-focus` | | ||
| | `theme.canvas.palette.common.focusOutline` | `brand.common.focus` | `brand.common.focus` | `--cnvs-brand-common-focus` | |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| | `theme.canvas.palette.common.focusOutline` | `brand.common.focus` | `brand.common.focus` | `--cnvs-brand-common-focus` | | |
| | `theme.canvas.palette.common.focusOutline` | `brand.common.focusOutline` | `brand.common.focus` | `--cnvs-brand-common-focus` | |
Workday/canvas-kit
|
||||||||||||||||||||||||||||||||||||||||
| Project |
Workday/canvas-kit
|
| Branch Review |
dark-mode-tokens
|
| Run status |
|
| Run duration | 02m 59s |
| Commit |
|
| Committer | Raisa Primerova |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
17
|
|
|
0
|
|
|
940
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
14.61%
|
|
|---|---|
|
|
2558
|
|
|
435
|
Accessibility
99.58%
|
|
|---|---|
|
|
3 critical
5 serious
3 moderate
1 minor
|
|
|
72
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #1234
Release Category
Components
Release Note
Optional release note message. Changelog and release summaries will contain a pull request title. This section will add additional notes under that title. This section is not a summary, but something extra to point out in release notes. An example might be calling out breaking changes in a labs component or minor visual changes that need visual regression updates. Remove this section if no additional release notes are required.
BREAKING CHANGES
Optional breaking changes message. If your PR includes breaking changes. It is extremely rare to put breaking changes outside a
prerelease/majorbranch. Anything in this section will show up in release notes. Remove this section if no breaking changes are present.Checklist
ready for reviewhas been added to PRFor the Reviewer
Where Should the Reviewer Start?
Areas for Feedback? (optional)
Testing Manually
Screenshots or GIFs (if applicable)
Thank You Gif (optional)