Repository navigation
chore: Merge support into master - #4237
Conversation
…ast element (#4229) Fixes: #4228 `InformationHighlight.Body` always applied `margin-block-end`, even when nothing followed it. The margin is meant to separate Body from content below it (typically `InformationHighlight.Link`), so when Body is the last element it added unnecessary space at the bottom of the component. Design confirmed this is a bug. This is a CSS-only fix: `&:last-child { margin-block-end: 0 }` on the Body stencil. `:last-child` was chosen over `:has(+ link)` so it keeps working if other elements (e.g. a button) are placed after Body. `Heading` is not affected on `support` (it already has `margin: 0`). The same bug exists on `master`, where `Heading` is also affected; that will be fixed in a separate PR against `master` since `Body.tsx` differs substantially between the branches. [category:Components] Release Note: Removes the extra space below `InformationHighlight.Body` when it is the last element. Spacing is unchanged when a `Link` follows. Chromatic will show a visual diff on the "Only Body" states. Co-authored-by: @cursoragent <cursoragent@cursor.com>
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Workday/canvas-kit
|
||||||||||||||||||||||||||||||||||||||||
| Project |
Workday/canvas-kit
|
| Branch Review |
merge/support-into-master
|
| Run status |
|
| Run duration | 02m 44s |
| Commit |
|
| Committer | Alan B Smith |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
17
|
|
|
0
|
|
|
940
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
14.54%
|
|
|---|---|
|
|
2572
|
|
|
435
|
Accessibility
99.57%
|
|
|---|---|
|
|
3 critical
5 serious
3 moderate
1 minor
|
|
|
73
|
This pull request was automatically created by an automated forward-merge job. The automated job failed automated checks and must be resolved manually.
Reasons for failure may include:
The pull request should inform you of merge conflicts before you start if any.
If there were no merge conflicts, the forward-merge job failed because of a test failure. You can wait for the pull request to give errors, or you can check the logs for failures. You'll have to update code to fix errors.
This pull request will be merged using the
mergestrategy instead of thesquashstrategy. This means any commit in the log will show in the branch's history. Any commit you make should amend the merge commit. Use the following command:You must then force-push the branch and the CI will rerun verification.
Use the
automergelabel like normal and the CI will pick the correct merge strategy.Summary by CodeRabbit