Skip to content

Fixed : Inconsistent behaviour when zero bytes are passed in size_format() #7248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
narenin wants to merge 4 commits into
base: trunk
Choose a base branch
from
+4 −0
Open

Fixed : Inconsistent behaviour when zero bytes are passed in size_format() #7248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bf5787f
Fixed : Inconsistent behaviour when zero bytes are passed in size_for…
narenin Aug 27, 2024
09394a7
Implemented other cases of 0
narenin Sep 2, 2024
4d557df
Merge branch 'trunk' into 61930-fixed-size-format-string-zero
westonruter Sep 2, 2026
69a742c
Cast $bytes to int
westonruter Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/wp-includes/functions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,6 +486,7 @@ function size_format( $bytes, $decimals = 0 ) {
_x( 'B', 'unit symbol' ) => 1,
);

$bytes = (int) $bytes;
if ( 0 === $bytes ) {
/* translators: Unit symbol for byte. */
return number_format_i18n( 0, $decimals ) . ' ' . _x( 'B', 'unit symbol' );
Expand Down
3 changes: 3 additions & 0 deletions tests/phpunit/tests/functions/sizeFormat.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ public function data_size_format() {
array( -1, 0, false ),
// Bytes.
array( 0, 0, '0 B' ),
array( '0', 0, '0 B' ),
array( '0.0', 0, '0 B' ),
array( 0.0e3, 0, '0 B' ),
array( 1, 0, '1 B' ),
array( 1023, 0, '1,023 B' ),
// Kilobytes.
Expand Down
Loading