Skip to content

Media: Prevent PHP warnings in wp_get_missing_image_subsizes() when image dimensions are missing - #14861

Open
abhishekfdd wants to merge 1 commit into
WordPress:trunkfrom
abhishekfdd:fix/57813-missing-image-dimensions
Open

abhishekfdd wants to merge 1 commit into
WordPress:trunkfrom
abhishekfdd:fix/57813-missing-image-dimensions

Conversation

@abhishekfdd

Copy link
Copy Markdown

The template has a required "Use of AI Tools" section, so I filled it in. Please check that the "Used for" line matches how you see it.

wp_get_missing_image_subsizes() reads $image_meta['width'] and $image_meta['height'] without checking that they exist. For attachments whose metadata lacks dimensions (SVGs added by plugins, broken uploads, migrated content), this triggers "Undefined array key" warnings.

This PR uses isset() checks so that missing dimensions fall back to 0. The return value is unchanged; only the warning is removed. With a zero dimension, image_resize_dimensions() rules out every sub-size, so the function still returns an empty array, and the result still passes through the wp_get_missing_image_subsizes filter exactly as before.

Testing

New test class Tests_Media_wpGetMissingImageSubsizes:

  • 4 missing-dimension cases (SVG with no dimensions, JPEG with no dimensions, JPEG with no width, JPEG with no height): on trunk all 4 fail with the Undefined array key "width" / Undefined array key "height" warning; with this fix all 4 pass.
  • Filter test: asserts the wp_get_missing_image_subsizes filter is still called, receiving an empty array and the attachment ID, when width/height are missing.
  • Control test: an image with valid dimensions still reports missing sub-sizes (e.g. thumbnail).

Commands:

npm run test:php -- --filter Tests_Media_wpGetMissingImageSubsizes
npm run test:php -- --group media
npm run test:php -- --group image

All pass. phpcs is clean on both changed files.

Trac ticket: https://core.trac.wordpress.org/ticket/57813

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Local environment setup, running tests, implementing the fix, adding the filter test, and coding-standards cleanup; the changes were reviewed by me.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

… image dimensions are missing.

When the attachment metadata does not contain a `width` or `height` value, for example for SVG files added by plugins, broken uploads, or migrated content, `wp_get_missing_image_subsizes()` would trigger "Undefined array key" warnings.

Missing dimensions now fall back to `0`. The return value is unchanged: no sub-sizes are considered possible without both dimensions, so an empty array is still returned and passed through the `wp_get_missing_image_subsizes` filter.

Includes unit tests.

See #57813.
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props abhishekfdd.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant