Repository navigation
Conversation
…::register()`. The docblock gave 'ai_provider' as the only example, which reads as if it were the only valid value. Document that any non-empty string is accepted, what 'ai_provider' changes, how other types behave, and that the type is part of the default setting name. See #66146. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
The AI Client key check, the handoff to the AI Client and the key-based connection status only apply to connectors using the `api_key` method. Connectors using `application_password` count as connected when both a username and a password are stored, whatever their type. See #66146. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Documents the connector
typeargument ofWP_Connector_Registry::register(), following comment:4 and comment:7 on the ticket:typeis free-form and may be shared; what core does differently for'ai_provider'(not registered whenwp_supports_ai()is false, key checked with the AI Client on save and cleared if invalid, passed to the AI Client, which also decides whether it is connected); how other types behave; and that the type is part of the defaultsetting_name. Each statement was checked againstconnectors.phpandclass-wp-connector-registry.php.Trac ticket: https://core.trac.wordpress.org/ticket/66146
Testing
vendor/bin/phpunit --filter Tests_Connectorspasses.Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: drafting the docblock and checking each statement against the code. I reviewed every line.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.
🤖 Generated with Claude Code