Skip to content

Twenty Nineteen: Replace node-sass with Dart Sass #13380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manzoorwanijk wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

Twenty Nineteen: Replace node-sass with Dart Sass #13380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b87daad
Twenty Nineteen: Replace node-sass with Dart Sass.
manzoorwanijk Sep 3, 2026
fc436d4
Twenty Nineteen: Preserve non-latin font fallbacks under Dart Sass.
manzoorwanijk Sep 3, 2026
5bc6ed5
Twenty Nineteen: Use the font-family mixin for the main navigation bu…
manzoorwanijk Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4,125 changes: 481 additions & 3,644 deletions src/wp-content/themes/twentynineteen/package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

14 changes: 7 additions & 7 deletions src/wp-content/themes/twentynineteen/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@
"@wordpress/browserslist-config": "^6.34.0",
"autoprefixer": "^10.4.22",
"chokidar-cli": "^3.0.0",
"node-sass": "^9.0.0",
"npm-run-all": "^4.1.5",
"postcss": "^8.5.6",
"postcss-cli": "^11.0.1",
"postcss-focus-within": "^9.0.1",
"rtlcss": "^4.3.0"
"rtlcss": "^4.3.0",
"sass": "^1.83.0"
},
"rtlcssConfig": {
"options": {
Expand All @@ -38,12 +38,12 @@
"extends @wordpress/browserslist-config"
],
"scripts": {
"build:style": "node-sass style.scss style.css --output-style expanded && postcss -r style.css",
"build:style-editor": "node-sass style-editor.scss style-editor.css --output-style expanded && postcss -r style-editor.css",
"build:style-editor-customizer": "node-sass style-editor-customizer.scss style-editor-customizer.css --output-style expanded && postcss -r style-editor-customizer.css",
"build:style": "sass style.scss:style.css --style=expanded --no-source-map && postcss -r style.css",
"build:style-editor": "sass style-editor.scss:style-editor.css --style=expanded --no-source-map && postcss -r style-editor.css",
"build:style-editor-customizer": "sass style-editor-customizer.scss:style-editor-customizer.css --style=expanded --no-source-map && postcss -r style-editor-customizer.css",
"build:rtl": "rtlcss style.css style-rtl.css",
"build:print": "node-sass print.scss print.css --output-style expanded && postcss -r print.css",
"build": "run-p \"build:*\"",
"build:print": "sass print.scss:print.css --style=expanded --no-source-map && postcss -r print.css",
"build": "run-s \"build:*\"",
"watch": "chokidar \"**/*.scss\" -c \"npm run build\" --initial"
}
}
3 changes: 1 addition & 2 deletions src/wp-content/themes/twentynineteen/print.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,7 @@ Andreas Hecht in https://www.jotform.com/blog/css-perfect-print-stylesheet-98272
.site-header.featured-image .main-navigation li,
.site-header.featured-image .social-navigation li,
.site-header.featured-image .entry-meta,
.site-header.featured-image .entry-title,
.site-header.featured-image#masthead .site-title a {
.site-header.featured-image .entry-title, .site-header.featured-image#masthead .site-title a {
color: #000;
text-shadow: none;
}
Expand Down
9 changes: 0 additions & 9 deletions src/wp-content/themes/twentynineteen/sass/mixins/_mixins-master.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,13 +129,4 @@
@extend %non-latin-fonts;
}

/* Build our non-latin font styles */
%non-latin-fonts {
@each $lang, $font__fallback in $font__fallbacks {
&:lang(#{$lang}) {
font-family: unquote( $font__fallback );
}
}
}

@import "utilities";
13 changes: 13 additions & 0 deletions src/wp-content/themes/twentynineteen/sass/mixins/_non-latin-fonts.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
/* Build our non-latin font styles.
*
* Imported last from each entry point so these rules follow the font-family
* declarations they override. Dart Sass drops contextual @extend selectors it
* considers redundant, so they can no longer rely on specificity alone.
*/
%non-latin-fonts {
@each $lang, $font__fallback in $font__fallbacks {
&:lang(#{$lang}) {
font-family: unquote( $font__fallback );
}
}
}
2 changes: 1 addition & 1 deletion src/wp-content/themes/twentynineteen/sass/navigation/_menu-main-navigation.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
border: none;
padding: 0;
margin: 0;
font-family: $font__heading;
@include font-family( $font__heading );
font-weight: 700;
line-height: $font__line-height-heading;
text-decoration: none;
Expand Down
2,582 changes: 1,192 additions & 1,390 deletions src/wp-content/themes/twentynineteen/style-editor.css
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions src/wp-content/themes/twentynineteen/style-editor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1101,3 +1101,7 @@ $group-block-background__padding: $font__size_base;
.wp-calendar-table {
@include font-family( $font__heading );
}

/* Non-latin font fallbacks. Must be imported last, see the partial. */

@import "sass/mixins/non-latin-fonts";
5,048 changes: 2,167 additions & 2,881 deletions src/wp-content/themes/twentynineteen/style-rtl.css
View file
Open in desktop

Large diffs are not rendered by default.

5,048 changes: 2,167 additions & 2,881 deletions src/wp-content/themes/twentynineteen/style.css
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions src/wp-content/themes/twentynineteen/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,3 +115,7 @@ Colorful Bokeh by HD Wallpapers, CC0. https://stocksnap.io/photo/colorful-bokeh-
/* Media */

@import "sass/media/media";

/* Non-latin font fallbacks. Must be imported last, see the partial. */

@import "sass/mixins/non-latin-fonts";
Loading