Build/Test Tools: Remove redundant Playwright setup in E2E CI. - #13369
Closed
adimoldovan wants to merge 4 commits into
Closed
Build/Test Tools: Remove redundant Playwright setup in E2E CI.#13369adimoldovan wants to merge 4 commits into
adimoldovan wants to merge 4 commits into
Conversation
The workflow installs Chromium. The suite runs no other browser. `wp-scripts test-playwright` then runs `playwright install` again, which downloads Firefox and WebKit and warns about libraries they need. Set PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD on the test step when the workflow installs the browsers.
On ubuntu-24.04 the runner image already provides every shared library Chromium needs. The apt step reports each one as already the newest version. `--with-deps` then installs 9 font packages, 21.1 MB, and adds about 27 seconds to every E2E job. Those fonts cover CJK, Thai, and Cyrillic. No spec in tests/e2e uses those scripts, the workflow installs only de_DE, and no spec asserts on a screenshot. The performance workflow keeps `--with-deps`. Its metrics feed a trend, and a font change could shift them.
adimoldovan
changed the title
`playwright install chromium` reads plainly on its own. The reason for leaving out `--with-deps` belongs in the ticket, not in the workflow.
adimoldovan
changed the title
adimoldovan
marked this pull request as ready for review
September 3, 2026 10:29
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
adimoldovan
requested review from
desrosj,
johnbillion,
lancewillett and
lucatume
September 3, 2026 10:29
swissspidy
approved these changes
Sep 3, 2026
|
Verified: reviewed the workflow diff and confirmed the gating logic ( |
lancewillett
approved these changes
Sep 3, 2026
pento
pushed a commit
that referenced
this pull request
Sep 3, 2026
The workflow installs Chromium before running the suite. Prevent `wp-scripts test-playwright` from installing Chromium, Firefox, and WebKit again when that setup has already run. Also stop passing `--with-deps`, which only adds unused fonts on the current Ubuntu runner. Developed in: #13369 Props adrianmoldovanwp, swissspidy, ugyensupport. Fixes #66035. git-svn-id: https://develop.svn.wordpress.org/trunk@63446 602fd350-edb4-49c9-b593-d223f7449a82
github-project-automation
Bot
moved this from In review
to Done
in WordPress Project Build Tooling
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Sep 3, 2026
The workflow installs Chromium before running the suite. Prevent `wp-scripts test-playwright` from installing Chromium, Firefox, and WebKit again when that setup has already run. Also stop passing `--with-deps`, which only adds unused fonts on the current Ubuntu runner. Developed in: WordPress/wordpress-develop#13369 Props adrianmoldovanwp, swissspidy, ugyensupport. Fixes #66035. Built from https://develop.svn.wordpress.org/trunk@63446 git-svn-id: http://core.svn.wordpress.org/trunk@62627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/66035
The E2E workflow does two pieces of Playwright setup that nothing uses.
A second browser install.
wp-scripts test-playwrightrunsnpx playwright installwith no browser argument, which installs Chromium, Firefox, and WebKit. An earlier step already installed Chromium, so every job downloads Firefox and WebKit and never opens them. SettingPLAYWRIGHT_SKIP_BROWSER_DOWNLOADon theRun E2E testsstep makeswp-scriptsskip it.--with-deps. Onubuntu-24.04, every shared library Chromium needs reportsalready the newest version. The flag installs nine font packages instead, covering CJK, Thai, Cyrillic, and the X core fonts. No spec intests/e2euses those scripts, the workflow installs onlyde_DE, and no spec asserts on a screenshot.Before, on trunk run 33649288756:
After, on run 33661004598 for this branch: none of those lines appear, Chromium and the headless shell still install, and both jobs pass 27 tests, the same count as the trunk run. Each job finished about a minute sooner. A single pair of runs makes that figure noisy; the removed work accounts for roughly 36 seconds of it.
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5
Used for: Reviewing these changes against the CI job logs and the
@wordpress/scriptssource.This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.