Build/Test Tools: Copy the local environment configuration synchronously in 6.7 - #13350
Build/Test Tools: Copy the local environment configuration synchronously in 6.7#13350adimoldovan wants to merge 1 commit into
Conversation
Backport of [62871] to the 6.7 branch. `start.js` copied `.env.example` asynchronously, then read `.env` on the next line. On a fresh checkout the read can win, and the process then runs with no configuration. Copy synchronously instead, guarded by `existsSync`, so `.env` exists before `dotenv.config()` runs. Dropping the swallow-all callback also lets a real copy error surface.
8cc70fa to
d4a59d8
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Merges [62871] to the 6.7 branch. Developed in: #13350 Reviewed by: johnbillion. Props jonsurrell, lucasbustamante, mukesh27, adrianmoldovanwp. See #65745. git-svn-id: https://develop.svn.wordpress.org/branches/6.7@63425 602fd350-edb4-49c9-b593-d223f7449a82
|
Committed to the 6.7 branch in r63425. |
github-project-automation
Bot
moved this from In review
to Done
in WordPress Project Build Tooling
2 participants
Backport of r62871 to the
6.7branch, from #12697.Trac ticket: https://core.trac.wordpress.org/ticket/65745
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.