Skip to content

Twenty Seventeen: Recheck blockquote position when widgets change in the Customizer - #13328

Draft
R1shabh-Gupta wants to merge 1 commit into
WordPress:trunkfrom
R1shabh-Gupta:fix/46055-customizer-blockquote-sidebar-refresh
Draft

Twenty Seventeen: Recheck blockquote position when widgets change in the Customizer#13328
R1shabh-Gupta wants to merge 1 commit into
WordPress:trunkfrom
R1shabh-Gupta:fix/46055-customizer-blockquote-sidebar-refresh

Conversation

@R1shabh-Gupta

Copy link
Copy Markdown

Fixes an issue where a right- or left-aligned blockquote, including the Quote block, can be overlapped by sidebar widget content when widgets are added, updated, or removed in the Customizer.

belowEntryMetaClass() in assets/js/global.js only runs on page load and window resize. Because of this, it does not recalculate when widgets are changed through Customizer selective refresh.

This change listens to the sidebar-updated event for the Blog Sidebar (sidebar-1) and reruns the existing check whenever its widgets are updated.

Trac ticket: https://core.trac.wordpress.org/ticket/46055

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Sonnet 5
Used for: Investigating the issue, implementing the fix, and verifying it locally. I reviewed the implementation before finalizing it.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant