Skip to content

Embeds: Handle deeply nested links in the embed click handler #13244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
itzmekhokan wants to merge 3 commits into from
Closed

Embeds: Handle deeply nested links in the embed click handler #13244

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
73a854d
Embeds: Handle deeply nested links in the embed click handler.
itzmekhokan Aug 24, 2026
cc597ba
Embeds: Resolve embed link clicks via the href property.
itzmekhokan Aug 27, 2026
4c1f9d7
Embeds: Use optional chaining for the resolved link href.
itzmekhokan Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions src/js/_enqueues/lib/embed-template.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,13 +156,12 @@
* Detect clicks to external (_top) links.
*/
function linkClickHandler( e ) {
var target = e.target,
href;
if ( target.hasAttribute( 'href' ) ) {
href = target.getAttribute( 'href' );
} else {
href = target.parentElement.getAttribute( 'href' );
}
/*
* The href property resolves to an absolute URL, which the parent window requires.
* Elements whose href is not a string, such as SVG anchors, are skipped.
*/
var link = e.target.closest( '[href]' ),
href = 'string' === typeof link?.href ? link.href : null;

// Only catch clicks from the primary mouse button, without any modifiers.
if ( event.altKey || event.ctrlKey || event.metaKey || event.shiftKey ) {
Expand Down
Loading