Skip to content

Fix orphaned transient timeout cleanup - #13101

Open
teams4evolve wants to merge 1 commit into
WordPress:trunkfrom
teams4evolve:fix/65863-orphaned-transient-timeout
Open

Fix orphaned transient timeout cleanup#13101
teams4evolve wants to merge 1 commit into
WordPress:trunkfrom
teams4evolve:fix/65863-orphaned-transient-timeout

Conversation

@teams4evolve

@teams4evolve teams4evolve commented Aug 17, 2026

Copy link
Copy Markdown

Trac ticket: https://core.trac.wordpress.org/ticket/65863

When the transient value row is missing, delete_transient() currently
does not remove the corresponding timeout row.

This changes delete_transient() and delete_site_transient() to always
attempt to delete their timeout rows.

Added regression tests covering orphaned transient timeout rows.

Tests:

  • vendor/bin/phpunit tests/phpunit/tests/option/transient.php
  • vendor/bin/phpunit tests/phpunit/tests/option/siteTransient.php
  • PHPCS passed for the changed files.

@github-actions

github-actions Bot commented Aug 17, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props elearningevolve.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@teams4evolve
teams4evolve force-pushed the fix/65863-orphaned-transient-timeout branch 2 times, most recently from ef813e2 to 3fd402a Compare August 17, 2026 13:24
@teams4evolve
teams4evolve force-pushed the fix/65863-orphaned-transient-timeout branch 3 times, most recently from 98a3500 to 55d4078 Compare August 31, 2026 10:10
…resolve cross-network collision.

- Updates delete_transient() and delete_site_transient() to always delete orphaned timeout rows.
- Updates delete_expired_transients() to delete expired orphaned transient and site transient timeouts across single-site (options table) and multisite (sitemeta table).
- Enforces b.site_id = a.site_id on both multisite cleanup queries to resolve cross-network data loss (#65969).
- Adds comprehensive single-site and multisite test coverage using factory-created networks.
- Documents the return value behavior in docblocks for delete_transient() and delete_site_transient().

Props team evolve.
Fixes #65863.
See #65969.
@teams4evolve
teams4evolve force-pushed the fix/65863-orphaned-transient-timeout branch from 55d4078 to 84ce8c1 Compare August 31, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant