Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/wp-admin/css/edit.css
Original file line number Diff line number Diff line change
Expand Up @@ -712,6 +712,17 @@ form#tags-filter {
margin-top: 3px;
}

#post-status-select select {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also it seems like on mobile we have a media query that adds left margin to the OK button, that seems off:

Image

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusted. The existing mobile rule for .save-post-status.button was adding an asymmetric offset that made sense for the previous inline layout, but looked off once the select became full-width. Status now shares the same mobile spacing as Visibility/Timestamp for the OK action, while clearing the old left offset.

display: block;
margin-bottom: 8px;
width: 100%;
}
Comment on lines +715 to +719

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this change since that way the buttons don't really shift depending on the width of the selected value. This is even more relevant on languages where those strings are longer.

But it seems like max-width is not necessary?

Suggested change
#post-status-select select {
max-width: 100%;
width: 100%;
}
#post-status-select select {
width: 100%;
}

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I removed max-width. I kept display: block and margin-bottom so the OK/Cancel controls sit below the full-width select without requiring a markup wrapper.

Comment on lines +715 to +719

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the dropdown is full-width, the "Cancel" button doesn't seem vertically aligned with the "OK" button:

Image

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusted. The Status OK/Cancel controls now get a scoped vertical-align: middle rule so the two actions align without changing the existing markup.


#post-status-select .save-post-status,
#post-status-select .cancel-post-status {
vertical-align: middle;
}

#linksubmitdiv .inside, /* Old Link Manager back-compat. */
#poststuff #submitdiv .inside {
margin: 0;
Expand Down Expand Up @@ -1894,12 +1905,17 @@ table.links-table {
line-height: 280%;
}

.wp-core-ui #post-status-select .save-post-status.button,
.wp-core-ui .save-post-visibility,
.wp-core-ui .save-timestamp {
vertical-align: middle;
margin-right: 15px;
}

.wp-core-ui #post-status-select .save-post-status.button {
margin-left: 0;
}

.timestamp-wrap select#mm {
display: block;
width: 100%;
Expand Down
Loading