Skip to content

#58969: Fix double-click copying "Copied!" notice text to clipboard in Privacy Policy Guide #12008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
masteradhoc wants to merge 4 commits into from
Closed

#58969: Fix double-click copying "Copied!" notice text to clipboard in Privacy Policy Guide #12008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
063c6eb
fix copied message inside clipboard
masteradhoc May 28, 2026
60a60f3
Merge branch 'WordPress:trunk' into 58969-copied
masteradhoc Jul 7, 2026
bebaa24
wrap privacy policy content in div
masteradhoc Jul 7, 2026
365aca3
remove old logic, add new div logic
masteradhoc Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/js/_enqueues/admin/privacy-tools.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,8 +296,10 @@ jQuery( function( $ ) {
range = document.createRange();
$parent.addClass( 'hide-privacy-policy-tutorial' );

// Copy action.
range.selectNodeContents( $parent[0] );
// Copy action. Select only the dedicated copy-content wrapper
// so the actions toolbar (which contains the "Copied!" notice
// and button label) is never part of the selection - see #58969.
range.selectNodeContents( $parent.find( '.privacy-text-copy-content' )[0] );
window.getSelection().addRange( range );
document.execCommand( 'copy' );

Expand Down
10 changes: 6 additions & 4 deletions src/wp-admin/includes/class-wp-privacy-policy-content.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,10 +420,12 @@ public static function privacy_policy_guide() {
</button>
</h4>
<div id="privacy-settings-accordion-block-<?php echo $i; ?>" class="privacy-settings-accordion-panel privacy-text-box-body" hidden="hidden">
<?php
echo $removed;
echo $section['policy_text'];
?>
<div class="privacy-text-copy-content">
<?php
echo $removed;
echo $section['policy_text'];
?>
</div>
<?php if ( empty( $section['removed'] ) ) : ?>
<div class="privacy-settings-accordion-actions">
<span class="success" aria-hidden="true"><?php _e( 'Copied!' ); ?></span>
Expand Down
Loading